chore(repo): Add DTS generation as separate script #5189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9752719 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
commented
Feb 18, 2025
| "compilerOptions": { | ||
| "allowSyntheticDefaultImports": true, | ||
| "baseUrl": ".", | ||
| "declaration": true, |
There was a problem hiding this comment.
When touching the existing tsconfig.json I removed properties that are defined in tsconfig.declarations.json, just cleaning things up
LekoArts
commented
Feb 18, 2025
| "build": "tsup --env.NODE_ENV production", | ||
| "build:analyze": "tsup --env.NODE_ENV production --metafile; open https://esbuild.github.io/analyze/", | ||
| "build:declarations": "tsc --env.NODE_ENV production -p tsconfig.json", | ||
| "build:declarations": "tsc -p tsconfig.declarations.json", |
There was a problem hiding this comment.
--env.NODE_ENV isn't valid for tsc
jacekradko
reviewed
Feb 19, 2025
Co-authored-by: Jacek Radko <jacek@clerk.dev>
LekoArts
deleted the
lekoarts/eco-371-generate-declaration-maps-in-sdks-separately
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a replacement for #5122
In this PR I'm not changing the published output of our packages but rather add a separate build script to our root
package.json(and adjusting the respective scripts in the individual packages).It's on purpose that the script isn't integrated into our CI yet and only touches a couple of SDKs, this and other things will follow in another PR.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change