feat(clerk-js,clerk-react,types): Navigate to tasks on after sign-in/sign-up #5280

LauraBeatris · 2025-03-04T17:40:00Z

Description

Introduces navigation to tasks after sign-in/sign-up for UI components and custom flows:

CleanShot.2025-03-06.at.19.33.15-converted.mp4

Developer flow

It doesn't require changes on the setActive signature, since the navigation is triggered within Clerk once the session transitions to pending

What's next:

Introduce a Clerk.load option (tasksUrl) for resolving URLs for tasks on custom flows
Handle redirection after resolving tasks

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-03-04T17:40:04Z

🦋 Changeset detected

Latest commit: b10bf3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/types	Minor
@clerk/clerk-react	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/agent-toolkit	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/expo-passkeys	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/nextjs	Patch
@clerk/nuxt	Patch
@clerk/react-router	Patch
@clerk/remix	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch
@clerk/vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-03-04T17:40:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 12, 2025 10:05pm

packages/clerk-js/src/core/clerk.ts

packages/clerk-js/src/core/resources/SessionTask.ts

panteliselef

Looks good to 🚢 Some minor comments are

Update changeset to include @clerk/clerk-react
Avoid logging for <SignIn/> being unable to render when user can access '/sign-in/add-organization'

LauraBeatris · 2025-03-12T21:27:07Z

I'm currently doing more tests on SSO callbacks + combined flows that trigger setActive with a pending session. Once @panteliselef gets addressed, then I'll proceed with merging.

- Use the typed constant when declaring Route components to catch breaking changes on `path` changes - Call `setComponentNavigationContext` within SignIn/SignUp root components to trigger cleanup on unmount, instead of relying on `BaseRouter` - Remove cleanup for `Clerk.#componentNavigationContext` withi `Clerk.#handlePendingSession`

LauraBeatris · 2025-03-12T22:22:45Z

Regarding the SSO callback flow -> It navigates to task when FAPI redirects to /sso-callback since it calls setActive with the pending session

However, it's not working if the sign-in is already created on FAPI, and it's redirecting to the redirectUrlComplete which doesn't trigger the navigation

There are two ways to approach (in a next PR):

We trigger the navigation once the client gets updated -> find some way to react to this instead of relying on setActive
FAPI navigates to /sso-callback or a new route such as /sign-in/task-callback

LauraBeatris self-assigned this Mar 4, 2025

LauraBeatris changed the title ~~feat(clerk-js): Navigate to tasks within SignIn/SignUp component~~ [WIP] feat(clerk-js): Navigate to tasks within SignIn/SignUp component Mar 4, 2025

clerk-cookie added types clerk-js integration labels Mar 4, 2025

LauraBeatris mentioned this pull request Mar 4, 2025

feat(clerk-js,types): Navigate to session task on after sign-in/sign-up #5187

Closed

9 tasks

vercel bot deployed to Preview March 4, 2025 23:05 View deployment

LauraBeatris force-pushed the laura/after-auth-1 branch from c15f966 to fafd3b7 Compare March 4, 2025 23:07

vercel bot deployed to Preview March 4, 2025 23:08 View deployment

LauraBeatris force-pushed the laura/after-auth-1 branch from 63ef78b to 1770981 Compare March 5, 2025 01:03

vercel bot deployed to Preview March 5, 2025 01:04 View deployment

LauraBeatris force-pushed the laura/after-auth-1 branch from 1770981 to 83ae82c Compare March 5, 2025 01:06

vercel bot deployed to Preview March 5, 2025 01:07 View deployment

LauraBeatris force-pushed the laura/after-auth-1 branch from 83ae82c to e09b5e7 Compare March 5, 2025 01:40

vercel bot deployed to Preview March 5, 2025 01:41 View deployment

vercel bot deployed to Preview March 5, 2025 01:51 View deployment

LauraBeatris force-pushed the laura/after-auth-1 branch from 7a6ad6d to 82034aa Compare March 5, 2025 02:15

vercel bot deployed to Preview March 5, 2025 02:15 View deployment

LauraBeatris requested review from brkalow and panteliselef March 5, 2025 02:29

LauraBeatris changed the title ~~[WIP] feat(clerk-js): Navigate to tasks within SignIn/SignUp component~~ [WIP] feat(clerk-js): Navigate to tasks on after-auth Mar 5, 2025

LauraBeatris changed the title ~~[WIP] feat(clerk-js): Navigate to tasks on after-auth~~ [WIP] feat(clerk-js): Navigate to tasks on after sign-in/sign-up Mar 5, 2025

LauraBeatris force-pushed the laura/after-auth-1 branch from 82034aa to 5e62dd7 Compare March 5, 2025 02:32

vercel bot deployed to Preview March 5, 2025 02:32 View deployment

vercel bot deployed to Preview March 5, 2025 14:11 View deployment

izaaklauer reviewed Mar 5, 2025

View reviewed changes

packages/clerk-js/src/core/clerk.ts Outdated Show resolved Hide resolved

izaaklauer reviewed Mar 5, 2025

View reviewed changes

packages/clerk-js/src/core/resources/SessionTask.ts Outdated Show resolved Hide resolved

LauraBeatris force-pushed the laura/after-auth-1 branch from e10d5a7 to 29d71c8 Compare March 5, 2025 17:53

LauraBeatris changed the title ~~feat(clerk-js,types): Navigate to tasks on after sign-in/sign-up~~ feat(clerk-js,react,types): Navigate to tasks on after sign-in/sign-up Mar 12, 2025

LauraBeatris changed the title ~~feat(clerk-js,react,types): Navigate to tasks on after sign-in/sign-up~~ feat(clerk-js,clerk-react,types): Navigate to tasks on after sign-in/sign-up Mar 12, 2025

LauraBeatris requested a review from brkalow March 12, 2025 17:50

panteliselef approved these changes Mar 12, 2025

View reviewed changes

vercel bot deployed to Preview March 12, 2025 19:00 View deployment

LauraBeatris added 14 commits March 12, 2025 18:35

Add first draft of integration tests

c10c3e3

Update setActive to handle pending session status

0fc67c8

Handle internal component navigation

a0fa5c2

Introduce test coverage

18c7cd8

Introduce experimental prop for lazy loading routes

c8daa94

Send telemetry event

f34745a

Refactor internal routing to set on BaseRouter

250d69c

Refactor integration tests to use use long running apps

f27b7c2

Remove unused TokenUpdate dispatch

bb6c8dd

Remove unused null from type

a6fdfd5

Add comment to clarify temporary experimental.withSessionTasks

8f8fd26

Update effect call to re-run via dependencies

48179a4

Update changeset to include clerk-react

c95edab

LauraBeatris force-pushed the laura/after-auth-1 branch from 3722d1f to c95edab Compare March 12, 2025 21:42

vercel bot deployed to Preview March 12, 2025 21:43 View deployment

Update bundlewatch based on latest rebase

16d9332

vercel bot deployed to Preview March 12, 2025 21:51 View deployment

Update redirect guard warning based on task URL

b10bf3f

vercel bot deployed to Preview March 12, 2025 22:05 View deployment

LauraBeatris merged commit 725918d into main Mar 12, 2025
30 checks passed

LauraBeatris deleted the laura/after-auth-1 branch March 12, 2025 22:23

clerk-cookie mentioned this pull request Mar 12, 2025

ci(repo): Version packages #5332

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(clerk-js,clerk-react,types): Navigate to tasks on after sign-in/sign-up #5280

feat(clerk-js,clerk-react,types): Navigate to tasks on after sign-in/sign-up #5280

Uh oh!

LauraBeatris commented Mar 4, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 4, 2025 •

edited

Loading

Uh oh!

vercel bot commented Mar 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

panteliselef left a comment

Uh oh!

LauraBeatris commented Mar 12, 2025

Uh oh!

LauraBeatris commented Mar 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat(clerk-js,clerk-react,types): Navigate to tasks on after sign-in/sign-up #5280

feat(clerk-js,clerk-react,types): Navigate to tasks on after sign-in/sign-up #5280

Uh oh!

Conversation

LauraBeatris commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Developer flow

What's next:

Checklist

Type of change

Uh oh!

changeset-bot bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

LauraBeatris commented Mar 12, 2025

Uh oh!

LauraBeatris commented Mar 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LauraBeatris commented Mar 4, 2025 •

edited

Loading

changeset-bot bot commented Mar 4, 2025 •

edited

Loading

vercel bot commented Mar 4, 2025 •

edited

Loading