fix(clerk-js): Remove extra legal consent checkbox #5289
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1283f92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Does this PR only include the changeset or I'm missing something? 🤔 |
|
@alexcarpenter I think we are missing the actual implementation. |
| {!shouldShowForm && isLegalConsentEnabled && ( | ||
| <Form.ControlRow elementId='legalAccepted'> | ||
| <LegalCheckbox | ||
| {...formState.legalAccepted.props} | ||
| isRequired={fields.legalAccepted?.required} | ||
| /> | ||
| </Form.ControlRow> | ||
| )} |
There was a problem hiding this comment.
Doesn't thins removes it completely ? If we have another checkbox can you point me to it ?
There was a problem hiding this comment.
No, it gets passed through in fields. Not sure what the intention was, but this seemed to solve the issue.
And only when google is enabled:
There was a problem hiding this comment.
@octoper do you recall if this is needed or removing it breaks something that it is not obvious ?
There was a problem hiding this comment.
What I remember is that this was on the official iteration and if you checked the ToS and then clicked the Continue with X button you will sign up without asking legal consent again
alexcarpenter
deleted the
alexcarpenter/sdki-904-sign-up-should-hide-tos-when-only-ssosamlweb3-are-available
branch
|
Oh, actually never mind. I realized that after signing-up with social accounts, there is a separate screen asking for user consent. So this PR makes sense. Thanks~~ |
Description
Removes legal consent checkbox from sign-up start card when only social or web3 strategies are enabled.
Fixes SDKI-904
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change