Skip to content

fix(clerk-js): Remove extra legal consent checkbox #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
+5 −10
Merged

fix(clerk-js): Remove extra legal consent checkbox #5289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d50fa2
fix(clerk-js): Remove extra legal consent checkbox
alexcarpenter Mar 5, 2025
229ef5e
add changeset
alexcarpenter Mar 5, 2025
1283f92
remove
alexcarpenter Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/afraid-cats-study.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Removes legal consent checkbox from sign-up start card when only social or web3 strategies are enabled.
10 changes: 0 additions & 10 deletions packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ import { SignInContext, useCoreSignUp, useEnvironment, useSignUpContext } from '
import { descriptors, Flex, Flow, localizationKeys, useAppearance, useLocalizations } from '../../customizables';
import {
Card,
Form,
Header,
LegalCheckbox,
LoadingCard,
SocialButtonsReversibleContainerWithDivider,
withCardStateProvider,
Expand Down Expand Up @@ -320,14 +318,6 @@ function _SignUpStart(): JSX.Element {
/>
)}
</SocialButtonsReversibleContainerWithDivider>
{!shouldShowForm && isLegalConsentEnabled && (
<Form.ControlRow elementId='legalAccepted'>
<LegalCheckbox
{...formState.legalAccepted.props}
isRequired={fields.legalAccepted?.required}
/>
</Form.ControlRow>
)}
Comment on lines -323 to -330
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't thins removes it completely ? If we have another checkbox can you point me to it ?

Copy link
Member Author

@alexcarpenter alexcarpenter Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it gets passed through in fields. Not sure what the intention was, but this seemed to solve the issue.

Screenshot 2025-03-06 at 8 53 04 AM

And only when google is enabled:

Screenshot 2025-03-06 at 8 53 37 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoper do you recall if this is needed or removing it breaks something that it is not obvious ?

Copy link
Member

@octoper octoper Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I remember is that this was on the official iteration and if you checked the ToS and then clicked the Continue with X button you will sign up without asking legal consent again

{!shouldShowForm && <CaptchaElement />}
</Flex>
</Card.Content>
Expand Down
Loading