Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Mar 10, 2025

Description

Standardizing the names of internal (non-exported) components to use proper component naming convention

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 49587fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 4:40pm

Copy link
Contributor

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that there was a pattern before, but I don't mind updating it with a clearer name

@alexcarpenter
Copy link
Member

I'd argue that there was a pattern before, but I don't mind updating it with a clearer name

It's at conflict with the eslint rule though 😅

@jacekradko
Copy link
Member Author

@panteliselef Aligning it with the expectation of the ESlint rule, like @alexcarpenter mentioned

@jacekradko jacekradko merged commit 8a77e9b into main Mar 11, 2025
30 checks passed
@jacekradko jacekradko deleted the fix/use-correct-component-names branch March 11, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants