fix(clerk-js): Handle two factor redirect when authenticate with web3 #5352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
3902d48 to
091af83
Compare
🦋 Changeset detectedLatest commit: 23e05da The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
091af83 to
054d34e
Compare
nikospapcom
changed the title
factor-two when authenticate with web3 and response status is needs_second_factor
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
054d34e to
f57c9d1
Compare
nikospapcom
requested review from
anagstef,
chanioxaris,
octoper and
panteliselef
anagstef
reviewed
Mar 18, 2025
Member
anagstef
left a comment
anagstef
left a comment
There was a problem hiding this comment.
Is it possible to add an integration test for this? 🤔
panteliselef
requested changes
Mar 18, 2025
packages/clerk-js/src/core/clerk.ts
Outdated
| }); | ||
| switch (signInOrSignUp.status) { | ||
| case 'needs_second_factor': | ||
| await navigate('factor-two'); |
Member
There was a problem hiding this comment.
This assumes usage is always with in our components which is not the case.
Sounds like we need to borrow a few things from handleRedirectCallback.
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
f57c9d1 to
540e1b5
Compare
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
540e1b5 to
7df6eba
Compare
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
7df6eba to
290aaf3
Compare
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
290aaf3 to
f2f804c
Compare
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
f2f804c to
eabb329
Compare
panteliselef
approved these changes
Apr 7, 2025
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
eabb329 to
09f38bd
Compare
…nd response status is `needs_second_factor`
nikospapcom
force-pushed
the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
from
09f38bd to
23e05da
Compare
Contributor
Author
@anagstef we don't have e2e for web3 apps right, that's the reason I didn't add tests |
nikospapcom
deleted the
nikospap/user-1350-we-fail-to-navigate-to-mfa-page-using-web3-wallet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pr we're handling the redirect to
two-factorwhen user try to login with web3 and has enabled theMulti-factor authenticationChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
BEFORE
Screen.Recording.2025-03-18.at.11.19.54.AM.mov
AFTER
Screen.Recording.2025-03-18.at.11.18.31.AM.mov