fix(clerk-js,types,localizations): Allow user set primary web3 wallet in <UserProfile />
#5353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9f92d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nikospapcom
changed the title
<UserProfile /> when more than one web3 wallets presented<UserProfile />
nikospapcom
force-pushed
the
nikospap/user-1351-missing-ability-to-change-primary-web3-wallet-from
branch
from
caccdb5 to
ff730b8
Compare
nikospapcom
requested review from
Nikpolik,
anagstef,
chanioxaris,
kostaspt,
octoper and
panteliselef
octoper
reviewed
Mar 14, 2025
.changeset/strong-chefs-travel.md
Outdated
| --- | ||
| '@clerk/localizations': patch | ||
| '@clerk/clerk-js': patch | ||
| '@clerk/types': patch |
There was a problem hiding this comment.
I believe these should be minor
octoper
approved these changes
Mar 14, 2025
anagstef
approved these changes
Mar 14, 2025
anagstef
reviewed
Mar 14, 2025
packages/localizations/src/en-US.ts
Outdated
| title: 'Username', | ||
| }, | ||
| web3WalletsSection: { | ||
| detailsAction__nonPrimary: 'Set as primary', |
There was a problem hiding this comment.
@nikospapcom you can run the generate.ts script inside the localizations package to add this key to all the localizations
panteliselef
approved these changes
Mar 15, 2025
Comment on lines
+119
to
+121
| const [setPrimary] = useReverification(() => { | ||
| return user?.update({ primaryWeb3WalletId: walletId }); | ||
| }); |
… in `<UserProfile />` when more than one web3 wallets presented
nikospapcom
force-pushed
the
nikospap/user-1351-missing-ability-to-change-primary-web3-wallet-from
branch
from
ff730b8 to
c9f92d7
Compare
chanioxaris
approved these changes
Mar 17, 2025
nikospapcom
deleted the
nikospap/user-1351-missing-ability-to-change-primary-web3-wallet-from
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
AFTER
Screen.Recording.2025-03-14.at.5.51.56.PM.mov