Skip to content

Conversation

@LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Mar 26, 2025

Description

This PR updates our Typedoc version to 0.28, see its changelog: https://typedoc.org/documents/Changelog.html#v0280-2025-03-15

There were a couple of breaking changes in this version that mostly the markdown plugin had to handle, but since we override parts of its theme I had to update our code, too. So that's why there are changes in custom-theme.mjs.

The reason why I did the upgrade was that Typedoc 0.28 added a --router option which now allows for a better way to modify the output.

Fixes ECO-507

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ⬜️ Skipped (Inspect) Mar 26, 2025 10:59am

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: d4058fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are accounting for upstream changes in the markdown plugin and the breaking changes in Typedoc itself

}, 'RedirectToSignUp');

/**
* @function
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typedoc is now more strict about const foo = () => {} vs function bar() {}.

Without the @function keyword it marks the former as a variable, not a function. Since I didn't want to change the function signature everywhere (since that should be enforced with ESLint) I just added the annotations

@LekoArts LekoArts marked this pull request as ready for review March 26, 2025 12:09
@LekoArts LekoArts merged commit 1a1cc81 into main Mar 26, 2025
36 checks passed
@LekoArts LekoArts deleted the lekoarts/eco-507-use-typedoc-028 branch March 26, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants