-
Notifications
You must be signed in to change notification settings - Fork 403
feat(clerk-js): __session cookie Partitioned attribute #5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5f36e29
feat(clerk-js): __session cookie Partitioned attribute
jacekradko d30b121
changeset
jacekradko 09548bb
wip
jacekradko 3a8913c
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko 005cfde
partition cookie in secure context
jacekradko 65c7f90
Unset existing session cookies before setting them with Partitioned a…
jacekradko 3a0fffc
keeping order consistent
jacekradko 23e505c
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko 11eb8fa
wip
jacekradko e60b313
clean up
jacekradko afaf699
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko f296990
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko ce5bd65
bundle
jacekradko 58234a9
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko a7a8d16
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko a1a98de
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko 735662d
make sure SameSite=none when setting partitioned cookies
jacekradko 53e6785
setup chips variant
jacekradko 76f33cb
entry point
jacekradko 0989010
add CHIPS env
jacekradko ea5478c
switch based on CHIPS
jacekradko 2137ae9
wip
jacekradko d67db33
Merge branch 'main' into feat/session-cookie-partitioned
jacekradko 0c62cd0
rename production artifact
jacekradko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| --- | ||
|
|
||
| Setting the Partitioned attribute on \_\_session cookie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './index'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we actually shipping this variant or it is a temporary thing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would ship it and pin specific instances to it