Skip to content

fix(clerk-react): Type error in __experimental_nextTask#5556

Merged
nikosdouvlis merged 1 commit intomainfrom
fix-type-error
Apr 8, 2025
Merged

fix(clerk-react): Type error in __experimental_nextTask#5556
nikosdouvlis merged 1 commit intomainfrom
fix-type-error

Conversation

@LekoArts
Copy link
Copy Markdown
Contributor

@LekoArts LekoArts commented Apr 8, 2025

Description

While running the build:declarations script it fails here:

> @clerk/clerk-react@5.26.0 build:declarations /Users/lejoe/code/work/clerk-docker/javascript/packages/react
│ > tsc -p tsconfig.declarations.json
│
│ src/isomorphicClerk.ts:629:3 - error TS2416: Property '__experimental_nextTask' in type 'IsomorphicClerk' is not assignable to the same
│ property in base type 'IsomorphicLoadedClerk'.
│   Type '(params: NextTaskParams) => Promise<void>' is not assignable to type 'WithVoidReturn<(params?: NextTaskParams | undefined) => Pr
│ omise<void>>'.
│     Types of parameters 'params' and 'params' are incompatible.
│       Type 'NextTaskParams | undefined' is not assignable to type 'NextTaskParams'.
│         Type 'undefined' is not assignable to type 'NextTaskParams'.
│
│ 629   __experimental_nextTask = async (params: NextTaskParams): Promise<void> => {

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 9:03am

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 8, 2025

🦋 Changeset detected

Latest commit: 05a5bc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts LekoArts changed the title fix(clerk-react): Type error in __experimental_nextTask fix(clerk-react): Type error in __experimental_nextTask Apr 8, 2025
@nikosdouvlis nikosdouvlis merged commit 6b38ab9 into main Apr 8, 2025
34 of 35 checks passed
@nikosdouvlis nikosdouvlis deleted the fix-type-error branch April 8, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants