feat(clerk-js,clerk-react): Introduce sessionClaims in useAuth()
#5565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4f8868 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panteliselef
force-pushed
the
elef/sdki-987-sessionclaims-missing-from-useauth-return
branch
from
917b511 to
1670fd0
Compare
panteliselef
changed the title
sessionClaims in useAuth()
…auth-return # Conflicts: # packages/clerk-js/bundlewatch.config.json
panteliselef
commented
Apr 9, 2025
Comment on lines
371
to
375
| if (token.jwt) { | ||
| this.lastActiveToken = token; | ||
| // Emits the updated session with the new token to the state listeners | ||
| eventBus.dispatch(events.SessionTokenResolved, null); | ||
| } |
There was a problem hiding this comment.
For reviewers:
useAuth() and useSession() were not re-rendering when the poller would generate a new token. This is necessary in order for useAuth().sessionClaims and useSession().lastActiveToken.jwt to have the correct content always, without waiting on client piggybacking.
panteliselef
commented
Apr 9, 2025
9 tasks
Signed-off-by: panteliselef <panteliselef@outlook.com>
…auth-return # Conflicts: # packages/clerk-js/bundlewatch.config.json # packages/clerk-js/src/core/resources/Session.ts
panteliselef
deleted the
elef/sdki-987-sessionclaims-missing-from-useauth-return
branch
4 tasks
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original PR
This PR acts as a ground work for
useAuth().sessionClaimslastActiveTokeneach time/tokenresolves successfullyChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change