Skip to content

fix(shared): Remove padding from parsePermissions #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

fix(shared): Remove padding from parsePermissions #5620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527b3a6
fix(shared): Remove padding from `parsePermissions`.
panteliselef Apr 14, 2025
0504399
add changeset
panteliselef Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-teeth-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Bug fix: Remove padding when parsing permissions from the JWT v2 format.
55 changes: 55 additions & 0 deletions packages/shared/src/__tests__/jwtPayloadParser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,61 @@ describe('JWTPayloadToAuthObjectProperties', () => {
['org:memberships:read', 'org:memberships:manage'].sort(),
);
});

test('org permissions are constructed correctly case 2', () => {
const { sessionClaims: v2Claims, ...signedInAuthObject } = JWTPayloadToAuthObjectProperties({
...baseClaims,
v: 2,
fea: 'o:billing,o:email,o:fraud,o:instance,o:staging_plans',
o: {
id: 'org_id',
rol: 'admin',
slg: 'org_slug',
per: 'manage,read',
fpm: '3,3,3,3,1',
},
});

expect(signedInAuthObject.orgPermissions?.sort()).toEqual(
[
'org:billing:manage',
'org:billing:read',
'org:email:manage',
'org:email:read',
'org:fraud:manage',
'org:fraud:read',
'org:instance:manage',
'org:instance:read',
'org:staging_plans:manage',
].sort(),
);
});

test('org permissions are constructed correctly case 3', () => {
const { sessionClaims: v2Claims, ...signedInAuthObject } = JWTPayloadToAuthObjectProperties({
...baseClaims,
v: 2,
fea: 'o:repositories,o:projects',
o: {
id: 'org_id',
rol: 'admin',
slg: 'org_slug',
per: 'read,create,update,delete,revoke',
fpm: '7,21',
},
});

expect(signedInAuthObject.orgPermissions?.sort()).toEqual(
[
'org:repositories:read',
'org:repositories:create',
'org:repositories:update',
'org:projects:read',
'org:projects:update',
'org:projects:revoke',
].sort(),
);
});
});

describe('splitByScope ', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/shared/src/jwtPayloadParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const parsePermissions = ({ per, fpm }: { per?: string; fpm?: string }) =
.map((permission: number) =>
permission
.toString(2)
.padStart(permissions.length, '0')
.split('')
.map(bit => Number.parseInt(bit, 10)),
)
Expand Down