-
Notifications
You must be signed in to change notification settings - Fork 421
feat(e2e): Add ensureBapiUserExists method #5647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
tmilewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 Looks good, but I'm not sure that I would expect this method (naming-wise) to create a user. Maybe something like findOrCreateBapiUser would make more sense?
Description
Adds a new
ensureBapiUserExistsfor e2e tests that need to ensure the suer exists, but don't care if they're created or already exist.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change