Skip to content

Conversation

@dstaley
Copy link
Member

@dstaley dstaley commented Apr 16, 2025

Description

Adds a new ensureBapiUserExists for e2e tests that need to ensure the suer exists, but don't care if they're created or already exist.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 8:40pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 6fc231a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 Looks good, but I'm not sure that I would expect this method (naming-wise) to create a user. Maybe something like findOrCreateBapiUser would make more sense?

@tmilewski tmilewski changed the title feat(e2e): add ensureBapiUserExists method feat(integration): add ensureBapiUserExists method Apr 16, 2025
@tmilewski tmilewski changed the title feat(integration): add ensureBapiUserExists method feat(e2e): add ensureBapiUserExists method Apr 16, 2025
@tmilewski tmilewski changed the title feat(e2e): add ensureBapiUserExists method feat(e2e): Add ensureBapiUserExists method Apr 16, 2025
@dstaley dstaley merged commit d97c934 into main Apr 17, 2025
30 checks passed
@dstaley dstaley deleted the ds.feat/ensureBapiUserExists branch April 17, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants