feat(e2e): Use Turbopack in Next.js app router e2e #5784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c360901 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dstaley
commented
May 1, 2025
| .setEnvFormatter('public', key => `NEXT_PUBLIC_${key}`) | ||
| .addScript('setup', constants.E2E_NPM_FORCE ? 'pnpm install --force' : 'pnpm install') | ||
| .addScript('dev', 'pnpm dev') | ||
| .addScript('dev', constants.E2E_NEXTJS_VERSION === '13' ? 'pnpm dev:webpack' : 'pnpm dev') |
There was a problem hiding this comment.
Next.js v13 does not support next dev --turbo.
dstaley
commented
May 1, 2025
| experimental: { | ||
| serverActions: true, | ||
| }, | ||
| outputFileTracingRoot: '/', |
There was a problem hiding this comment.
By default, Turbopack doesn't resolve files outside of the project root. We use pnpm link to install dependencies, which exist outside of the root. We set the outputFileTracingRoot to the root / directory to allow Turbopack to resolve dependency files from anywhere on disk.
dstaley
changed the title
tmilewski
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our Next.js App Router template to use Turbopack by default. While this doesn't dramatically decrease the execution time, it does make them slightly faster to run locally.
The improved performance of Turbopack versus Webpack surfaced an issue with how we use
signInWithEmailAndInstantPasswordin the billing tests. Since we performed a navigation immediately after calling the signIn method, the page was reloaded before the sign-in could be completed. This is because Turbopack was able to response with the HTML for the document request faster than Webpack. This was fixed by adding a new parameter to the method,waitForSession(defaults totrue) that will wait forwindow.Clerk.sessionto the truthy before resolving the promise.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change