fix(clerk-js): Add Partitioned to __client_uat in CHIPS build #5785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 46770c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue by sending the Partitioned attribute for the __session cookie when building for CHIPS.
- Updates cookie options in clientUat.ts to conditionally set the sameSite and partitioned attributes.
- Adds new tests for the clientUat cookie behavior in various contexts.
- Enhances test coverage in both session and clientUat tests to ensure expected cookie creation, setting, and removal.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/clerk-js/src/core/auth/cookies/clientUat.ts | Updated cookie options with a new Partitioned attribute and adjusted sameSite strategy |
| packages/clerk-js/src/core/auth/cookies/tests/session.test.ts | Added tests to validate session cookie creation and prioritization between suffixed and non-suffixed cookies |
| packages/clerk-js/src/core/auth/cookies/tests/clientUat.test.ts | Added tests to validate clientUat cookie behavior across different contexts |
jacekradko
changed the title
jacekradko
changed the title
brkalow
approved these changes
May 2, 2025
Comment on lines
+8
to
+11
| jest.mock('@clerk/shared/cookie'); | ||
| jest.mock('@clerk/shared/date'); | ||
| jest.mock('../../../../utils'); | ||
| jest.mock('../../getSecureAttribute'); |
Comment on lines
+57
to
+58
| suffixedClientUatCookie.set(val, { domain, expires, partitioned, sameSite, secure }); | ||
| clientUatCookie.set(val, { domain, expires, partitioned, sameSite, secure }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like this was missed in the initial change to send the Partitioned attribute for the
__sessioncookieChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change