fix(clerk-js): Allow only members with manage billing permission to manage billing in OP #5835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9ea3961 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
changed the title
octoper
changed the title
octoper
force-pushed
the
vaggelis/org-permissions-billing-section
branch
from
5092115 to
d113913
Compare
| variant='info' | ||
| colorScheme='info' | ||
| title={localizationKeys( | ||
| 'organizationProfile.__experimental_billingPage.alerts.noPemissionsToManageBilling', |
Member
There was a problem hiding this comment.
should we still be including the __experimental_ prefixes still?
Member
alexcarpenter
left a comment
alexcarpenter
left a comment
There was a problem hiding this comment.
I am not sure about disabling the buttons in PricingTable without any info as to why.
# Conflicts: # packages/localizations/src/en-US.ts
octoper
force-pushed
the
vaggelis/org-permissions-billing-section
branch
from
938e520 to
fbfd56c
Compare
alexcarpenter
approved these changes
May 5, 2025
brkalow
reviewed
May 6, 2025
wobsoriano
pushed a commit
that referenced
this pull request
May 6, 2025
…anage billing in OP (#5835) Co-authored-by: Keiran Flanigan <keiran@aeliox.com> Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com> Co-authored-by: Bryce Kalow <bryce@clerk.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Member without any billing permissions
Organization Profile
Pricing table
Member with only
org:sys_billing:readOrganization Profile with a subscription
Organization Profile without active paid plan
Available plans screen
See all features drawer
Pricing Table
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change