Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented May 5, 2025

Description

This PR sets the Vue integration tests to use local version of clerk-js, as well as updating SDK metadatas

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: 6f9d36e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/vue Patch
@clerk/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 6:42pm

@wobsoriano wobsoriano changed the title chore(repo): Use E2E_CLERK_VERSION in vue and nuxt integration presets chore(vue,nuxt): Add default SDK Metadata and use E2E_CLERK_VERSION May 5, 2025
@wobsoriano wobsoriano marked this pull request as ready for review May 5, 2025 17:45
@wobsoriano wobsoriano changed the title chore(vue,nuxt): Add default SDK Metadata and use E2E_CLERK_VERSION chore(vue,nuxt): Add default SDK Metadata and fix integration tests May 5, 2025
Comment on lines +10 to +11
clerkJSUrl: import.meta.env.VITE_CLERK_JS_URL,
clerkJSVersion: import.meta.env.VITE_CLERK_JS_VERSION,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the actual fix

@wobsoriano wobsoriano merged commit 8c1f7c3 into main May 5, 2025
32 checks passed
@wobsoriano wobsoriano deleted the rob/use-e2e-clerk-version-vue branch May 5, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants