refactor(clerk-js,types): Update subscriptions listing UI #5847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4a2c958 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
changed the title
alexcarpenter
commented
May 6, 2025
| export { default as CheckCircle } from './check-circle.svg'; | ||
| export { default as CheckmarkFilled } from './checkmark-filled.svg'; | ||
| export { default as ChevronDown } from './chevron-down.svg'; | ||
| export { default as ChevronUpDown } from './chevron-up-down.svg'; |
Member
Author
There was a problem hiding this comment.
Renamed ArrowUpDown to be ChevronUpDown to account for the newly added ArrowsUpDown icon.
No change in output:
alexcarpenter
commented
May 6, 2025
Comment on lines
295
to
328
| billingPage: { | ||
| subscriptionsListSection: { | ||
| actionLabel__switchPlan: 'Switch plans', | ||
| title: 'Subscription', | ||
| }, | ||
| paymentSourcesSection: { | ||
| actionLabel__default: 'Make default', | ||
| actionLabel__remove: 'Remove', | ||
| add: 'Add new payment method', | ||
| addSubtitle: 'Add a new payment method to your account.', | ||
| cancelButton: 'Cancel', | ||
| formButtonPrimary__add: 'Add Payment Method', | ||
| formButtonPrimary__pay: 'Pay {{amount}}', | ||
| payWithTestCardButton: 'Pay with test card', | ||
| removeResource: { | ||
| messageLine1: '{{identifier}} will be removed from this account.', | ||
| messageLine2: | ||
| 'You will no longer be able to use this payment source and any recurring subscriptions dependent on it will no longer work.', | ||
| successMessage: '{{paymentSource}} has been removed from your account.', | ||
| title: 'Remove payment method', | ||
| }, | ||
| title: 'Payment methods', | ||
| }, | ||
| start: { | ||
| headerTitle__invoices: 'Invoices', | ||
| headerTitle__plans: 'Plans', | ||
| headerTitle__subscriptions: 'Subscriptions', | ||
| }, | ||
| subscriptionsSection: { | ||
| actionLabel__default: 'Manage', | ||
| }, | ||
| title: 'Billing', | ||
| }, | ||
| }, |
Member
Author
There was a problem hiding this comment.
Update localizations to be scope to the profile they are within.
brkalow
deleted the
alexcarpenter/com-744-update-subscriptions-tab-and-table-layout
branch
wobsoriano
pushed a commit
that referenced
this pull request
May 6, 2025
Co-authored-by: Bryce Kalow <bryce@clerk.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates SubscriptionsList UI to be within a profile section. Also fixes localization issue, where we were rendering userProfile scoped localizations within organizationProfile.
Org Profile:
User Profile:
Resolves COM-744
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change