Skip to content

fix(clerk-js): Display generic payment icon in payment source row when payment method is not card #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

fix(clerk-js): Display generic payment icon in payment source row when payment method is not card #5851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-foxes-add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Display generic payment icon in payment source row when payment method is not card
6 changes: 3 additions & 3 deletions packages/clerk-js/src/ui/components/PaymentSources/PaymentSourceRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { CommercePaymentSourceResource } from '@clerk/types';

import { Badge, descriptors, Flex, Icon, localizationKeys, Text } from '../../customizables';
import { ApplePay, CreditCard } from '../../icons';
import { CreditCard, GenericPayment } from '../../icons';

export const PaymentSourceRow = ({ paymentSource }: { paymentSource: CommercePaymentSourceResource }) => {
return (
Expand All @@ -12,7 +12,7 @@ export const PaymentSourceRow = ({ paymentSource }: { paymentSource: CommercePay
elementDescriptor={descriptors.paymentSourceRow}
>
<Icon
icon={paymentSource.walletType === 'apple_pay' ? ApplePay : CreditCard}
icon={paymentSource.paymentMethod === 'card' ? CreditCard : GenericPayment}
sx={{ alignSelf: 'center' }}
elementDescriptor={descriptors.paymentSourceRowIcon}
/>
Expand All @@ -29,7 +29,7 @@ export const PaymentSourceRow = ({ paymentSource }: { paymentSource: CommercePay
truncate
elementDescriptor={descriptors.paymentSourceRowValue}
>
{paymentSource.paymentMethod === 'card' ? `⋯ ${paymentSource.last4}` : '-'}
{paymentSource.paymentMethod === 'card' ? `⋯ ${paymentSource.last4}` : null}
</Text>
{paymentSource.isDefault && (
<Badge
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/icons/generic-pay.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/icons/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export { default as Eye } from './eye.svg';
export { default as EyeSlash } from './eye-slash.svg';
export { default as Fingerprint } from './fingerprint.svg';
export { default as Folder } from './folder.svg';
export { default as GenericPayment } from './generic-pay.svg';
export { default as InformationCircle } from './information-circle.svg';
export { default as LinkIcon } from './link.svg';
export { default as LockClosedIcon } from './lock-closed.svg';
Expand Down
Loading