feat(clerk-js,localization): Add notice when member does not have permissions to manage billing #5852
Conversation
🦋 Changeset detectedLatest commit: 155b55d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/clerk-js/sandbox/app.ts
Outdated
| Clerk.mountPricingTable(app, { | ||
| forOrganizations: true, | ||
| }); |
There was a problem hiding this comment.
Will remove this too before merging
| type="text/javascript" | ||
| src="/<%= htmlRspackPlugin.files.js[0] %>" | ||
| data-clerk-publishable-key="pk_test_dG91Y2hlZC1sYWR5YmlyZC0yMy5jbGVyay5hY2NvdW50cy5kZXYk" | ||
| data-clerk-publishable-key="pk_test_ZGV2b3RlZC15YWstMjkuY2xlcmsuYWNjb3VudHNzdGFnZS5kZXYk" |
There was a problem hiding this comment.
Left this for testing, will remove it before merge
| } | ||
|
|
||
| if (isDisabled) { | ||
| return children; |
There was a problem hiding this comment.
Is the below condition not working properly ?
packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx
Outdated
Show resolved
Hide resolved
| sx={{ | ||
| width: '100%', | ||
| }} | ||
| isDisabled={canManageBilling} |
There was a problem hiding this comment.
Doesn't the button have a isDisabled prop that we check for in the tooltip to handle wrapping with span to make it focusable?
There was a problem hiding this comment.
Removed in favor of reading disabled from the child element which works from my testing. Let me know if I am missing something.
packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx
Outdated
Show resolved
Hide resolved
…not have permissions to manage billing # Conflicts: # packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationBillingPage.tsx # packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx # packages/localizations/src/en-US.ts
octoper
force-pushed
the
vaggelis/add-tooltips-with-reason-if-no-permissions
branch
from
d888c19 to
c9cb7ad
Compare
… permissions to manage billing
alexcarpenter
deleted the
vaggelis/add-tooltips-with-reason-if-no-permissions
branch
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change