-
Notifications
You must be signed in to change notification settings - Fork 402
fix(clerk-js,types,localizations): Update plans page title #5889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js,types,localizations): Update plans page title #5889
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: adb101e The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 The en-US removals are intended, right? Just want to make sure as I don't see it called out in the PR description.
Yeah, I moved them to their own page object to follow suit with how other pages are keyed. Plans is its own page, but the title was coming from the billingPage object. Now we have a plansPage object that houses the localizations for that page. |
Description
Updates plan page title from
Switch planstoPlansin profile components.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change