fix(clerk-js): Ensure RTL is supported within Drawer component #5906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f859df The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+4
to
+19
| if (dir === 'rtl') { | ||
| return 'rtl'; | ||
| } | ||
|
|
||
| if (dir === 'ltr') { | ||
| return 'ltr'; | ||
| } | ||
|
|
||
| if (dir === 'auto' || !dir) { | ||
| const computedDirection = window.getComputedStyle(element).direction; | ||
| if (computedDirection === 'rtl') { | ||
| return 'rtl'; | ||
| } | ||
| } | ||
|
|
||
| return 'ltr'; |
Member
There was a problem hiding this comment.
can it be simplified to this ?
Suggested change
| if (dir === 'rtl') { | |
| return 'rtl'; | |
| } | |
| if (dir === 'ltr') { | |
| return 'ltr'; | |
| } | |
| if (dir === 'auto' || !dir) { | |
| const computedDirection = window.getComputedStyle(element).direction; | |
| if (computedDirection === 'rtl') { | |
| return 'rtl'; | |
| } | |
| } | |
| return 'ltr'; | |
| const default = 'ltr' | |
| if (dir === 'auto' || !dir) { | |
| const computedDirection = window.getComputedStyle(element).direction; | |
| return computedDirection || default; | |
| } | |
| return dir || default; |
Member
Author
There was a problem hiding this comment.
I added a test case why I went with the current approach. I think more explicit/defensive approach is right here, someone could hypothetically apply an invalid dir value as it's just an html attribute.
Comment on lines
+27
to
+29
| if (element) { | ||
| return getDirectionFromElement(element); | ||
| } |
Member
There was a problem hiding this comment.
Aren't we always using documen.documentElement inside drawer ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure drawer animation respects RTL usage.
Screen.Recording.2025-05-12.at.10.58.44.AM.mov
To test in the sanbox, add
dir="rtl"to the html element within thetemplate.htmlfile.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change