Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented May 15, 2025

Description

Add green success color animation to checkout complete.

Screen.Recording.2025-05-19.at.11.33.05.AM.mov

Animation visualization:

Screen.Recording.2025-05-19.at.11.48.46.AM.mov

Resolves COM-503

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: 9fa686d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 8:23pm

@alexcarpenter alexcarpenter marked this pull request as ready for review May 19, 2025 16:36
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 19, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@5940

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@5940

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@5940

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@5940

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@5940

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@5940

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@5940

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@5940

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@5940

@clerk/express

npm i https://pkg.pr.new/@clerk/express@5940

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@5940

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@5940

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@5940

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@5940

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@5940

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@5940

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@5940

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@5940

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@5940

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@5940

@clerk/types

npm i https://pkg.pr.new/@clerk/types@5940

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@5940

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@5940

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@5940

commit: 9fa686d

Copy link
Contributor

@aeliox aeliox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig it

zIndex: 1,
pointerEvents: 'none',
...(!canHover && {
display: 'none',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be cool if it just sat at a fixed spot on mobile / before interaction

Copy link
Member

@iagodahlem iagodahlem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@alexcarpenter alexcarpenter merged commit 5d35ae3 into main May 19, 2025
36 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/checkout-complete-success-animation branch May 19, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants