Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented May 16, 2025

Description

Fixes an issue where the keyless prompt was rendering above the newly added drawer component. To fix, we remove the z-index definition from the prompt. Alternatively I considered conditionally hiding the prompt when a drawer is open but the caused the initial expanded to always fire, even after it was closed once. So the z-index solution felt like the best approach.

Screen.Recording.2025-05-16.at.4.17.58.PM.mov

Fixes SDK-2115

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2025

🦋 Changeset detected

Latest commit: ad3a7d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 8:18pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 16, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@5951

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@5951

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@5951

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@5951

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@5951

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@5951

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@5951

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@5951

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@5951

@clerk/express

npm i https://pkg.pr.new/@clerk/express@5951

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@5951

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@5951

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@5951

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@5951

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@5951

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@5951

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@5951

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@5951

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@5951

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@5951

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@5951

@clerk/types

npm i https://pkg.pr.new/@clerk/types@5951

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@5951

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@5951

commit: ad3a7d9

@alexcarpenter alexcarpenter merged commit 1a3ac26 into main May 19, 2025
39 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdk-2115-layering-issue-with-claim-completed-dialog-during-billing-2 branch May 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants