Skip to content

fix(backend): Ensure SAMLConnection API responses are explicitly deserialized #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

fix(backend): Ensure SAMLConnection API responses are explicitly deserialized #5993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/weak-kings-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/backend': patch
---

Ensure SAMLConnection API responses are explicitly deserialized
3 changes: 3 additions & 0 deletions packages/backend/src/api/resources/Deserializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
PhoneNumber,
ProxyCheck,
RedirectUrl,
SamlConnection,
Session,
SignInToken,
SignUpAttempt,
Expand Down Expand Up @@ -125,6 +126,8 @@ function jsonToObject(item: any): any {
return ProxyCheck.fromJSON(item);
case ObjectType.RedirectUrl:
return RedirectUrl.fromJSON(item);
case ObjectType.SamlConnection:
return SamlConnection.fromJSON(item);
case ObjectType.SignInToken:
return SignInToken.fromJSON(item);
case ObjectType.SignUpAttempt:
Expand Down
2 changes: 2 additions & 0 deletions packages/backend/src/api/resources/JSON.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const ObjectType = {
ProxyCheck: 'proxy_check',
RedirectUrl: 'redirect_url',
SamlAccount: 'saml_account',
SamlConnection: 'saml_connection',
Session: 'session',
SignInAttempt: 'sign_in_attempt',
SignInToken: 'sign_in_token',
Expand Down Expand Up @@ -603,6 +604,7 @@ export interface PaginatedResponseJSON {
}

export interface SamlConnectionJSON extends ClerkResourceJSON {
object: typeof ObjectType.SamlConnection;
name: string;
domain: string;
organization_id: string | null;
Expand Down
Loading