-
Notifications
You must be signed in to change notification settings - Fork 402
fix(tanstack-react-start): Apply response headers #6057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tanstack-react-start): Apply response headers #6057
Conversation
🦋 Changeset detectedLatest commit: f15fc4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dios-david is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @octoper, tagging you as I saw that you contributed the most to this package. Can you take a look at this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome catch, thank you for the PR!
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
|
@wobsoriano 🙌 |
Description
I'm using
@tanstack/react-start@1.120.15and@clerk/tanstack-react-start@0.15.8in a project and I noticed that the Clerk response headers are not being set on the response, which is needed for some key functionalities (e.g. for the handshake).I noticed that the
getResponseClerkState()function already returns the headers, and they are added torouter.update(), but this doesn't seem to work.I applied these changes to my local project and I can confirm that I see the response headers now (
x-clerk-auth-reasonandx-clerk-auth-statuswhen not logged in), but I'm not sure what is the best way to fully verify this - I added a test case to the integration tests but I don't have access to run them.Any feedback or help would be much appreciated!
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change