Skip to content

Use @clerk/backend in gatsby-plugin-clerk#628

Closed
nikosdouvlis wants to merge 3 commits into
mainfrom
gatsby_backend
Closed

Use @clerk/backend in gatsby-plugin-clerk#628
nikosdouvlis wants to merge 3 commits into
mainfrom
gatsby_backend

Conversation

@nikosdouvlis
Copy link
Copy Markdown
Member

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/backend-core
  • @clerk/clerk-sdk-node
  • @clerk/edge
  • @clerk/shared
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

const frontendApi = process.env.GATSBY_CLERK_FRONTEND_API || '';
if (!apiKey || !frontendApi) {
// todo:
throw new Error('missing key');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Do we need to do the check at this point, or should we leave Clerk SDK to raise it? So far, we've followed the latter approach.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikosdouvlis Reminder☝️


return Clerk({ apiKey }).authenticateRequest({
apiKey,
// TODO: do we need the key?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The key can be removed. We will use JWKS by default.

Comment thread packages/backend/src/index.ts
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 8, 2023
@tmilewski tmilewski deleted the gatsby_backend branch November 9, 2023 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants