Use @clerk/backend in gatsby-plugin-clerk#628
Closed
nikosdouvlis wants to merge 3 commits into
Closed
Conversation
SokratisVidros
approved these changes
Dec 22, 2022
| const frontendApi = process.env.GATSBY_CLERK_FRONTEND_API || ''; | ||
| if (!apiKey || !frontendApi) { | ||
| // todo: | ||
| throw new Error('missing key'); |
Contributor
There was a problem hiding this comment.
🔧 Do we need to do the check at this point, or should we leave Clerk SDK to raise it? So far, we've followed the latter approach.
|
|
||
| return Clerk({ apiKey }).authenticateRequest({ | ||
| apiKey, | ||
| // TODO: do we need the key? |
Contributor
There was a problem hiding this comment.
No. The key can be removed. We will use JWKS by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/backend-core@clerk/clerk-sdk-node@clerk/edge@clerk/sharedbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.