Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Oct 14, 2025

Description

There seems to be an upstream issue with srvx package, which is being used by TanStack Start under the hood. Pinning a recent version for now.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Updated internal routing and application libraries to recent patch versions for improved stability and compatibility.
    • Added a small runtime helper dependency to support server-side execution paths; defaults preserve existing behavior.
    • Added placeholder release metadata to the repository.
    • No user-facing features, behavior, or API changes are expected.

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

🦋 Changeset detected

Latest commit: a5a392f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Oct 14, 2025 6:20pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Adds a placeholder changeset file and updates the tanstack-react-start integration template’s package.json to add a runtime dependency (srvx ^0.8.15) and bump three TanStack package versions. No code, scripts, or control-flow changes.

Changes

Cohort / File(s) Summary
Changeset placeholder
.changeset/honest-flies-destroy.md
Added a new changeset file containing only placeholder lines (---); no functional impact.
Integration template package
integration/templates/tanstack-react-start/package.json
Bumped TanStack packages: @tanstack/react-router 1.132.31 → 1.132.47, @tanstack/react-router-devtools 1.132.31 → 1.132.51, @tanstack/react-start 1.132.31 → 1.132.51; added runtime dependency "srvx": "^0.8.15". No scripts or other config changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers—two dashes in a file,
A quiet changeset laid down with a smile.
Srvx hopped in with a soft little thunk,
Versions nudged forward—then I took a bunk.
I nibble a carrot; the repo feels light. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely conveys that the PR is a chore to temporarily fix the TanStack Start integration test, accurately reflecting the main change without extraneous details or ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/pin-srvx-version

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fb5cc25 and a5a392f.

📒 Files selected for processing (1)
  • integration/templates/tanstack-react-start/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • integration/templates/tanstack-react-start/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
integration/templates/tanstack-react-start/package.json (1)

16-16: Prefer exact pin to stabilize integration tests

Using a caret range here can drift to newer 0.8.x and re-break tests. For a “temporary fix,” pin exactly to 0.8.15.

-    "srvx": "^0.8.15",
+    "srvx": "0.8.15",

Also confirm srvx is required at runtime by vite start (then keep it under dependencies, not devDependencies).

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dacc1af and 44d741c.

📒 Files selected for processing (2)
  • .changeset/honest-flies-destroy.md (1 hunks)
  • integration/templates/tanstack-react-start/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • integration/templates/tanstack-react-start/package.json
integration/**

📄 CodeRabbit inference engine (.cursor/rules/global.mdc)

Framework integration templates and E2E tests should be placed under the integration/ directory

Files:

  • integration/templates/tanstack-react-start/package.json
integration/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

End-to-end tests and integration templates must be located in the 'integration/' directory.

Files:

  • integration/templates/tanstack-react-start/package.json
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/honest-flies-destroy.md
🪛 LanguageTool
.changeset/honest-flies-destroy.md

[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---

(QB_NEW_DE)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build Packages
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dacc1af and 44d741c.

📒 Files selected for processing (2)
  • .changeset/honest-flies-destroy.md (1 hunks)
  • integration/templates/tanstack-react-start/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/honest-flies-destroy.md
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • integration/templates/tanstack-react-start/package.json
integration/**

📄 CodeRabbit inference engine (.cursor/rules/global.mdc)

Framework integration templates and E2E tests should be placed under the integration/ directory

Files:

  • integration/templates/tanstack-react-start/package.json
integration/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

End-to-end tests and integration templates must be located in the 'integration/' directory.

Files:

  • integration/templates/tanstack-react-start/package.json
🪛 LanguageTool
.changeset/honest-flies-destroy.md

[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---

(QB_NEW_DE)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment on lines +1 to +2
---
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Changeset is empty and will be rejected by tooling.

Changesets expect at least one package bump in the frontmatter plus a short summary. With only the delimiter lines, pnpm changeset version/CI will fail to parse this file, so the release pipeline breaks. Please add the appropriate package entry (e.g., "integration/templates/tanstack-react-start": patch) and a short description.

🧰 Tools
🪛 LanguageTool

[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---

(QB_NEW_DE)

🤖 Prompt for AI Agents
In .changeset/honest-flies-destroy.md around lines 1 to 2, the changeset
frontmatter is empty which causes tooling to reject it; add at least one package
bump entry and a short summary. Update the frontmatter YAML to include a package
and semver type (for example: "integration/templates/tanstack-react-start":
patch) and then add a one-line description body under the frontmatter explaining
the change (e.g., "patch: fix template dependency versions"), ensuring the file
contains valid YAML frontmatter and a non-empty summary so pnpm changeset
parsing succeeds.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 14, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6988

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6988

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6988

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6988

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6988

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6988

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6988

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6988

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6988

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6988

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6988

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6988

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6988

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6988

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6988

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6988

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6988

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6988

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6988

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6988

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6988

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6988

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6988

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6988

commit: a5a392f

@wobsoriano wobsoriano enabled auto-merge (squash) October 14, 2025 18:25
@wobsoriano wobsoriano merged commit fbdd473 into main Oct 14, 2025
41 checks passed
@wobsoriano wobsoriano deleted the rob/pin-srvx-version branch October 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants