-
Notifications
You must be signed in to change notification settings - Fork 402
fix(clerk-js): Handle Last Used SAML strategies #7135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Handle Last Used SAML strategies #7135
Conversation
🦋 Changeset detectedLatest commit: 9d45d86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a test for UI behavior when the last authentication strategy is SAML (Google) and normalizes SAML-prefixed strategy identifiers to their OAuth equivalents before validating and rendering the "Last used" badge. Changes
Sequence DiagramsequenceDiagram
participant UI as SignIn UI
participant Social as SocialButtons
UI->>Social: provide clientLastAuth = "saml_google"
activate Social
rect rgba(200,230,201,0.4)
Note right of Social: Normalization step
Social->>Social: converted = replacePrefix("saml_", "oauth_")
end
rect rgba(187,222,251,0.35)
Note right of Social: Validation
Social->>Social: isValidStrategy(converted) ? use converted : null
end
Social->>UI: render "Last used" badge and social buttons (using validated strategy)
deactivate Social
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Description
Handles the case where last used SAML strategies aren't matched with their appropriate social button counterpart.
This is related to a backend change, but can be safely released whenever necessary.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Bug Fixes
Tests