Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Nov 5, 2025

Description

Fixes missing dts files in published packages

Fixes #7144

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Restored missing TypeScript declaration files for the Expo package, improving TypeScript developer experience.
  • Chores
    • Adjusted build/configuration for the Expo package to ensure declaration generation (source root set and incremental declaration compilation disabled).

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 7fac7fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 5, 2025 2:42am

@wobsoriano
Copy link
Member Author

!snapshot

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Walkthrough

Creates a new changeset for a patch release of @clerk/clerk-expo and adds rootDir and incremental compiler options to the expo package TypeScript declarations tsconfig.

Changes

Cohort / File(s) Summary
Changeset addition
\.changeset/tricky-crabs-fetch.md
Adds a new changeset file for a patch release of @clerk/clerk-expo with description "Fixed missing declaration files."
TypeScript configuration
packages/expo/tsconfig.declarations.json
Adds rootDir: "./src" and incremental: false to the compilerOptions to set the declarations source root and disable incremental compilation for declaration generation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, focused metadata and configuration changes.
  • Areas to check:
    • Confirm rootDir matches project layout (packages/expo/src).
    • Verify declaration files are generated as expected and CI/publish includes them.

Poem

🐰 A patch-tiptoe, file in tow,
Types declared where they should grow,
Root set true, increments turned off,
A gentle hop — no more lost scoff. ✨

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: fixing missing TypeScript declaration files for the @clerk/clerk-expo package during build.
Linked Issues check ✅ Passed The code changes (adding rootDir and incremental compiler options) directly address the missing .d.ts files issue [#7144] by ensuring declaration files are generated during build.
Out of Scope Changes check ✅ Passed All changes are scoped to resolving missing declaration files: a changeset entry documenting the fix and tsconfig.declarations.json configuration changes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/fix-expo-dts-2

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dc67e40 and 7fac7fb.

📒 Files selected for processing (1)
  • .changeset/tricky-crabs-fetch.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/tricky-crabs-fetch.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@clerk-cookie
Copy link
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

Package Version
@clerk/clerk-expo 2.18.1-snapshot.v20251105022807

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/clerk-expo

npm i @clerk/clerk-expo@2.18.1-snapshot.v20251105022807 --save-exact

@wobsoriano
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

Package Version
@clerk/clerk-expo 2.18.1-snapshot.v20251105023017

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/clerk-expo

npm i @clerk/clerk-expo@2.18.1-snapshot.v20251105023017 --save-exact

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 5, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7149

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7149

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7149

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7149

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7149

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7149

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7149

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7149

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7149

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7149

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7149

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7149

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7149

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7149

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7149

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7149

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7149

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7149

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7149

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7149

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7149

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7149

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7149

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7149

commit: 7fac7fb

@wobsoriano
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

Package Version
@clerk/clerk-expo 2.18.1-snapshot.v20251105023343

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/clerk-expo

npm i @clerk/clerk-expo@2.18.1-snapshot.v20251105023343 --save-exact

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/expo/tsconfig.declarations.json (1)

5-5: Reconsider disabling incremental compilation.

Setting incremental: false explicitly disables TypeScript's incremental compilation feature, which is designed to improve build performance by caching information from previous compilations. Unless there is a specific reason this is incompatible with declaration-only emission or the DTS test workflow, consider removing this option to preserve the performance benefits of incremental builds.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9be829 and dc67e40.

📒 Files selected for processing (1)
  • packages/expo/tsconfig.declarations.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/expo/tsconfig.declarations.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build Packages
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
packages/expo/tsconfig.declarations.json (1)

1-15: Provide context and rationale for the TypeScript compiler option changes.

The PR description lacks details about the DTS test issue being fixed. Without understanding the original problem, it's difficult to validate whether these compiler option changes are the correct fix. Please clarify:

  1. What DTS test failure prompted this change?
  2. Why is rootDir: "./src" needed specifically for declaration generation in this monorepo context?
  3. Is incremental: false necessary, or could this negatively impact build performance?

@wobsoriano wobsoriano changed the title fix(clerk-expo): DTS test do not review fix(clerk-expo): Resolve missing declaration files on build Nov 5, 2025
@wobsoriano wobsoriano merged commit 85c5508 into main Nov 5, 2025
42 checks passed
@wobsoriano wobsoriano deleted the rob/fix-expo-dts-2 branch November 5, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Missing dist folder or types in @clerk/clerk-expo@2.17.4

4 participants