Skip to content

Conversation

@HwangSB
Copy link
Contributor

@HwangSB HwangSB commented Nov 11, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved Korean (ko-KR) localization by adding missing translations for form labels and input placeholders (first/last name, email, username), expiration options (7d–1y), and sign-in interface text (continued with application name). These updates replace previously blank entries so Korean users now see complete, meaningful UI text.

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2025

🦋 Changeset detected

Latest commit: 773a546

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 11, 2025

@HwangSB is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

Walkthrough

A changeset bumps @clerk/localizations patch version and updates ko-KR with Korean translations for previously undefined form captions, option labels, placeholders, and a sign-in title.

Changes

Cohort / File(s) Summary
Changeset entry
.changeset/afraid-papers-see.md
Adds a patch changeset for @clerk/localizations noting improvements to Korean (ko-KR) localization.
Korean localization updates
packages/localizations/src/ko-KR.ts
Fills previously undefined Korean strings: expiration caption ('{{ date }}에 만료'), expiration options ('180일','1일','1년','30일','60일','7일','90일'), email/name placeholders, and sign-in title ('{{applicationName}}로 계속').

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify translation accuracy and contextual fit.
  • Confirm all previously undefined keys are populated and match UI intent.

Poem

🐰 I nibble on strings, one by one,
Filling the blanks till the work is done,
'만료' sings clear, placeholders bright,
Korean words hoppin' into sight,
Users smile — localization delight.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and accurately describes the main change: improving Korean localization translations in the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b9596ab and 773a546.

📒 Files selected for processing (1)
  • packages/localizations/src/ko-KR.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/localizations/src/ko-KR.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4011c5e and b9596ab.

📒 Files selected for processing (2)
  • .changeset/afraid-papers-see.md (1 hunks)
  • packages/localizations/src/ko-KR.ts (3 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels

Files:

  • packages/localizations/src/ko-KR.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/ko-KR.ts
packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/ko-KR.ts
packages/**/*.{ts,tsx,d.ts}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Packages should export TypeScript types alongside runtime code

Files:

  • packages/localizations/src/ko-KR.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Prefer readonly for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Use const assertions for literal types: as const
Use satisfies operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports: import type { ... } from ...
No any types without justification
Proper error handling with typed errors
Consistent use of readonly for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)

Files:

  • packages/localizations/src/ko-KR.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (5)
packages/localizations/src/ko-KR.ts (4)

29-29: LGTM! Expiration caption translation is accurate.

The Korean translation '{{ date }}에 만료' correctly uses the template variable and natural Korean grammar.


31-37: LGTM! Expiration period translations are consistent and accurate.

All time period translations correctly use Korean counters ('일' for days, '년' for year) and follow a consistent pattern.


215-216: LGTM! Email placeholder translations are natural and appropriate.

The translations use the polite imperative form ('입력하세요') which is appropriate for user-facing UI text.


720-720: LGTM! Sign-in title translation is accurate.

The translation '{{applicationName}}로 계속' correctly uses the Korean particle '로' to express "continue with [application]" and properly preserves the template variable.

.changeset/afraid-papers-see.md (1)

1-7: LGTM! Changeset format and content are correct.

The changeset follows the proper format, uses an appropriate patch version bump for localization updates, and accurately describes the improvements to Korean translations.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@wobsoriano wobsoriano changed the title feat(localizations): improve Korean (ko-KR) translation chore(localizations): Improve Korean (ko-KR) translations Nov 12, 2025
Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jacekradko jacekradko merged commit d64638d into clerk:main Nov 12, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants