-
Notifications
You must be signed in to change notification settings - Fork 411
fix(repo): Add explicit dependencies to Nuxt preset for CI #7279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ea63b83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughA new changeset file is created as a placeholder, and the Nuxt preset integration is extended with conditional npm installation behavior based on an environment variable and three new Clerk package dependencies ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
31baaf1 to
ea63b83
Compare
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
integration/presets/nuxt.ts (1)
15-18: Consider consistent version override pattern across dependencies.Line 15 uses
constants.E2E_CLERK_VERSION || linkPackage('nuxt')to allow version overrides in CI, but lines 16-18 only uselinkPackage()without the version fallback. If these packages should also support version overrides in CI (e.g., when testing against specific published versions), consider applying the same pattern.If version override is needed for all dependencies:
.addDependency('@clerk/nuxt', constants.E2E_CLERK_VERSION || linkPackage('nuxt')) -.addDependency('@clerk/shared', linkPackage('shared')) -.addDependency('@clerk/types', linkPackage('types')) -.addDependency('@clerk/vue', linkPackage('vue')); +.addDependency('@clerk/shared', constants.E2E_CLERK_VERSION || linkPackage('shared')) +.addDependency('@clerk/types', constants.E2E_CLERK_VERSION || linkPackage('types')) +.addDependency('@clerk/vue', constants.E2E_CLERK_VERSION || linkPackage('vue'));Note: This suggestion assumes all Clerk packages would be published together with the same version. If the current pattern is intentional (only the main package needs version override), you can safely ignore this.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/seven-sites-tease.md(1 hunks)integration/presets/nuxt.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
integration/presets/nuxt.ts (1)
integration/presets/utils.ts (1)
linkPackage(3-10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
- GitHub Check: Integration Tests (quickstart, chrome, 15)
- GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
- GitHub Check: Integration Tests (billing, chrome, RQ)
- GitHub Check: Integration Tests (nextjs, chrome, 16)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (quickstart, chrome, 16)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (handshake:staging, chrome)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (sessions:staging, chrome)
- GitHub Check: Integration Tests (handshake, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Static analysis
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
integration/presets/nuxt.ts (2)
11-11: Constant is properly defined.Verification confirms that
constants.E2E_NPM_FORCEis defined at line 46 ofintegration/constants.tsasprocess.env.E2E_NPM_FORCE. The code correctly handles both cases: when the environment variable is set (uses--forceflag) and when undefined (standard install).
15-18: The review comment's claim is incorrect. The Nuxt and Next.js presets do not have the same dependency structure.Key differences:
- Nuxt preset includes
@clerk/vueas a dependency- Next.js preset does NOT include
@clerk/reactas a dependency (React is pulled via Next.js itself)The Nuxt preset appropriately includes its framework UI library (
@clerk/vue), while the Next.js preset does not add@clerk/reactseparately. This architectural difference is justified—Next.js already brings React through its core dependency, whereas Nuxt explicitly adds its Vue integration.The PR description's claim about "mirroring" the Next.js preset is inaccurate. The dependency structures follow appropriate patterns for their respective frameworks but are fundamentally different.
Likely an incorrect or invalid review comment.
Description
Nuxt integration tests were failing in CI due to missing explicit dependencies. Added
@clerk/shared,@clerk/types, and@clerk/vue, like we have for the Next.js preset.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.