Skip to content

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Nov 21, 2025

Description

Nuxt integration tests were failing in CI due to missing explicit dependencies. Added @clerk/shared, @clerk/types, and @clerk/vue, like we have for the Next.js preset.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Enhanced Nuxt integration configuration with conditional setup options based on environment settings
    • Added supplementary dependencies to expand Nuxt node capabilities

✏️ Tip: You can customize this high-level summary in your review settings.

@LauraBeatris LauraBeatris self-assigned this Nov 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: ea63b83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 21, 2025 0:17am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

A new changeset file is created as a placeholder, and the Nuxt preset integration is extended with conditional npm installation behavior based on an environment variable and three new Clerk package dependencies (@clerk/shared, @clerk/types, @clerk/vue) linked to the existing Nuxt node configuration.

Changes

Cohort / File(s) Summary
Changeset entry
.changeset/seven-sites-tease.md
Adds placeholder changeset file with YAML separators
Nuxt integration configuration
integration/presets/nuxt.ts
Extends setup script with conditional pnpm install --force behavior based on E2E_NPM_FORCE environment variable; adds three new Clerk package dependencies (@clerk/shared, @clerk/types, @clerk/vue) to nuxtNode configuration

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify that the three new Clerk package dependencies are correctly linked and compatible with the Nuxt preset
  • Confirm the E2E_NPM_FORCE environment variable logic is intended and properly documented

Poem

🐰 New packages hop into Nuxt's nest today,
Clerk's shared, types, and vue join the array,
Conditional installs when forces align,
Configuration grows, dependencies shine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main change: adding explicit dependencies to the Nuxt preset configuration for CI purposes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch laura/update-nuxt-tests-ci

Comment @coderabbitai help to get the list of available commands and usage tips.

@LauraBeatris LauraBeatris force-pushed the laura/update-nuxt-tests-ci branch from 31baaf1 to ea63b83 Compare November 21, 2025 00:16
@LauraBeatris LauraBeatris requested review from a team and wobsoriano November 21, 2025 00:16
@LauraBeatris LauraBeatris changed the title fix(integration): Add explicit dependencies to Nuxt preset for CI fix(ci): Add explicit dependencies to Nuxt preset for CI Nov 21, 2025
@LauraBeatris LauraBeatris changed the title fix(ci): Add explicit dependencies to Nuxt preset for CI fix(repo): Add explicit dependencies to Nuxt preset for CI Nov 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7279

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7279

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7279

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7279

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7279

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7279

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7279

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7279

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7279

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7279

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7279

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7279

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7279

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7279

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7279

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7279

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7279

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7279

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7279

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7279

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7279

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7279

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7279

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7279

commit: ea63b83

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
integration/presets/nuxt.ts (1)

15-18: Consider consistent version override pattern across dependencies.

Line 15 uses constants.E2E_CLERK_VERSION || linkPackage('nuxt') to allow version overrides in CI, but lines 16-18 only use linkPackage() without the version fallback. If these packages should also support version overrides in CI (e.g., when testing against specific published versions), consider applying the same pattern.

If version override is needed for all dependencies:

 .addDependency('@clerk/nuxt', constants.E2E_CLERK_VERSION || linkPackage('nuxt'))
-.addDependency('@clerk/shared', linkPackage('shared'))
-.addDependency('@clerk/types', linkPackage('types'))
-.addDependency('@clerk/vue', linkPackage('vue'));
+.addDependency('@clerk/shared', constants.E2E_CLERK_VERSION || linkPackage('shared'))
+.addDependency('@clerk/types', constants.E2E_CLERK_VERSION || linkPackage('types'))
+.addDependency('@clerk/vue', constants.E2E_CLERK_VERSION || linkPackage('vue'));

Note: This suggestion assumes all Clerk packages would be published together with the same version. If the current pattern is intentional (only the main package needs version override), you can safely ignore this.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bf5c953 and ea63b83.

📒 Files selected for processing (2)
  • .changeset/seven-sites-tease.md (1 hunks)
  • integration/presets/nuxt.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
integration/presets/nuxt.ts (1)
integration/presets/utils.ts (1)
  • linkPackage (3-10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
integration/presets/nuxt.ts (2)

11-11: Constant is properly defined.

Verification confirms that constants.E2E_NPM_FORCE is defined at line 46 of integration/constants.ts as process.env.E2E_NPM_FORCE. The code correctly handles both cases: when the environment variable is set (uses --force flag) and when undefined (standard install).


15-18: The review comment's claim is incorrect. The Nuxt and Next.js presets do not have the same dependency structure.

Key differences:

  • Nuxt preset includes @clerk/vue as a dependency
  • Next.js preset does NOT include @clerk/react as a dependency (React is pulled via Next.js itself)

The Nuxt preset appropriately includes its framework UI library (@clerk/vue), while the Next.js preset does not add @clerk/react separately. This architectural difference is justified—Next.js already brings React through its core dependency, whereas Nuxt explicitly adds its Vue integration.

The PR description's claim about "mirroring" the Next.js preset is inaccurate. The dependency structures follow appropriate patterns for their respective frameworks but are fundamentally different.

Likely an incorrect or invalid review comment.

@LauraBeatris LauraBeatris merged commit 5aa9aff into main Nov 21, 2025
111 of 119 checks passed
@LauraBeatris LauraBeatris deleted the laura/update-nuxt-tests-ci branch November 21, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants