Skip to content

Conversation

@kamil-homer
Copy link

@kamil-homer kamil-homer commented Dec 7, 2025

Description

undefined values caused the UI element to be displayed as an empty block.

before:
Zrzut ekranu 2025-12-7 o 12 59 27

after:
Zrzut ekranu 2025-12-7 o 13 25 43

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Expanded Polish language support with comprehensive translations for organization-management UI, including creation and selection flows, organization switcher labels, API key pages, sign‑out and account recovery screens, form fields, buttons, titles and help texts — improving locale completeness and replacing many placeholders with Polish strings.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2025

🦋 Changeset detected

Latest commit: 8b433ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 7, 2025

@kamil-homer is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

Adds Polish translations for multiple organization-related and task screens in the PL localization file and records the change in a patch changeset entry. Previously undefined or placeholder strings were populated with concrete Polish text.

Changes

Cohort / File(s) Summary
Changeset documentation
.changeset/whole-bikes-dig.md
Patch changeset entry recording the addition of Polish translations for Organizations UI elements.
Polish localization updates
packages/localizations/src/pl-PL.ts
Fills many previously undefined or placeholder keys with Polish strings across sections: organizationList, organizationProfile.apiKeysPage, organizationSwitcher, taskChooseOrganization (choose/create/join/invite flows), and taskResetPassword. Updates include titles, subtitles, action labels, form buttons, placeholders, and sign-out text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify translation accuracy and consistency with existing locale conventions.
  • Ensure no placeholder tokens or interpolation markers were altered incorrectly (e.g., {{identifier}}).
  • Confirm no unrelated keys were changed or removed.

Poem

🐇 Słowa w skórze polskiej zasiane,

Utworzono teksty — nie są już puste,
Klik, zapisz, przejdź — wszystko ładnie brzmi,
Króliczek skacze wśród napisów nowych,
Cieszy locale — hop, hurra! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding missing Polish translations to fix UI rendering issues in the localization file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6ffaaea and 8b433ec.

📒 Files selected for processing (1)
  • packages/localizations/src/pl-PL.ts (3 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/pl-PL.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/pl-PL.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/pl-PL.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/pl-PL.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/pl-PL.ts
🔇 Additional comments (7)
packages/localizations/src/pl-PL.ts (7)

267-276: Organization list actions now fully localized and consistent

The updated labels (action__createOrganization, createOrganization, subtitle, suggestionsAcceptedLabel) are natural Polish, reuse the same verb phrase “Utwórz organizację”, and keep the {{applicationName}} placeholder intact. No issues from a localization or interpolation standpoint.


278-280: API keys page title localized appropriately

Setting organizationProfile.apiKeysPage.title to 'Klucze API' matches standard Polish terminology and aligns with other API‑key‑related labels in this file. Looks good.


498-507: Organization switcher open/close and join actions localized correctly

The new strings for action__closeOrganizationSwitcher, action__openOrganizationSwitcher, and action__suggestionsAccept are concise, idiomatic, and consistent with the same actions elsewhere (e.g., organization list “Poproś o dołączenie”). Placeholders are unchanged and valid.


852-859: taskChooseOrganization.chooseOrganization block reads naturally

All actions and labels here (action__createOrganization, action__invitationAccept, action__suggestionsAccept, subtitle, suggestionsAcceptedLabel, title) are clear and idiomatic. The subtitle correctly describes the flow and there are no placeholder or grammar issues.


860-869: Create-organization task strings are clear and consistent with the rest of the locale

The CTA labels, placeholders ('Moja Organizacja', 'moja-organizacja'), and field labels ('Nazwa', 'Slug') are understandable and match expectations for this screen. Interpolations are not used here, so there is no templating risk.


870-873: Sign-out copy under taskChooseOrganization matches existing patterns

actionLink: 'Wyloguj' and actionText: 'Zalogowano jako {{identifier}}' reuse wording and interpolation style already used elsewhere (e.g., impersonationFab), so this should integrate smoothly with the rest of the UI.


875-883: Reset-password task CTAs localized; confirm whether subtitle should remain undefined

The new formButtonPrimary, signOut texts, and title are idiomatic and consistent with other password-reset flows. The adjacent subtitle is still undefined; if that key is rendered in the UI for this task, it may continue to show as an empty block, so it’s worth double‑checking whether it should also receive a Polish string in this PR.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano wobsoriano changed the base branch from main to release/core-2 December 9, 2025 22:14
@wobsoriano
Copy link
Member

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7390

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7390

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7390

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7390

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7390

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7390

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7390

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7390

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7390

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7390

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7390

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7390

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7390

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7390

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7390

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7390

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7390

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7390

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7390

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7390

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7390

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7390

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7390

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7390

commit: 8b433ec

@jacekradko jacekradko merged commit 893d3e4 into clerk:release/core-2 Dec 10, 2025
12 of 40 checks passed
wobsoriano added a commit that referenced this pull request Dec 10, 2025
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
wobsoriano added a commit that referenced this pull request Dec 10, 2025
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants