Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Dec 18, 2025

Description

Getting the astro tests to run locally

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Resolved compatibility issues with Astro/Vite package linking to improve local development behavior.
  • Chores

    • Added new dependency resolution entries to ensure consistent local package use.
    • Introduced tarball-based packaging and caching to stabilize builds and speed local linking.
    • Minor metadata/changeset file added.
  • Refactor

    • Simplified package linking logic (public linking helper signature updated).

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: 570086e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 18, 2025 7:48pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

📝 Walkthrough

Walkthrough

Adds @clerk/backend and @clerk/shared resolutions to the Astro preset configuration. Introduces tarball-based packaging in integration/presets/utils.ts: a tarball cache, a list of packages requiring tarballs, a pnpm pack helper, and centralized tarball creation used by linkPackage. Updates linkPackage signature to accept a single pkg parameter and routes specified packages through tarball paths outside CI while preserving previous behavior for other packages; in CI it returns *. Adds a new .changeset file with placeholder content.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main objective of the PR - fixing local Astro integration tests - which aligns with the primary changes made to enable running Astro integration tests locally.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ad4dd62 and ca710e6.

📒 Files selected for processing (2)
  • .changeset/bold-spoons-act.md (1 hunks)
  • integration/presets/utils.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/bold-spoons-act.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • integration/presets/utils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (shared, clerk-js, RQ)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 18, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7510

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7510

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7510

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7510

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7510

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7510

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7510

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7510

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7510

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7510

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7510

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7510

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7510

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7510

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7510

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7510

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7510

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7510

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7510

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7510

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7510

commit: 570086e

@jacekradko jacekradko merged commit 2c4ce1a into main Dec 18, 2025
42 checks passed
@jacekradko jacekradko deleted the feat/local-astro-tests branch December 18, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants