-
Notifications
You must be signed in to change notification settings - Fork 419
fix(backend): bundle cookie package to fix cjs/esm issues #7524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why: CJS cookie package causing module compatibility problems in Astro and TanStack Start What: Move cookie to devDependencies and bundle with tsup noExternal config
🦋 Changeset detectedLatest commit: 00dda79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
!snapshot |
📝 WalkthroughWalkthroughThis pull request moves the Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (26)
🔇 Additional comments (1)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/agent-toolkit@0.2.9-snapshot.v20251224145055 --save-exact
npm i @clerk/astro@3.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/backend@3.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/chrome-extension@3.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/clerk-js@6.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/dev-cli@1.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/expo@3.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/expo-passkeys@1.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/express@2.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/fastify@2.6.9-snapshot.v20251224145055 --save-exact
npm i @clerk/localizations@4.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/nextjs@7.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/nuxt@2.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/react@6.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/react-router@3.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/shared@4.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/tanstack-react-start@1.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/testing@2.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/ui@1.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/upgrade@2.0.0-snapshot.v20251224145055 --save-exact
npm i @clerk/vue@2.0.0-snapshot.v20251224145055 --save-exact |
wobsoriano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Why: CJS cookie package causing module compatibility problems in Astro and TanStack Start
What: Move cookie to devDependencies and bundle with tsup noExternal config
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.