fix(react): make __internal_* URL props take precedence over bundled constructors#7919
fix(react): make __internal_* URL props take precedence over bundled constructors#7919jacekradko merged 2 commits intomainfrom
Conversation
…constructors When both a bundled Clerk/ClerkUI constructor and an __internal_*Url prop are provided, the URL prop now takes precedence. This ensures testing overrides (e.g. staging/canary builds) are not silently ignored.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3dd794a The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes make internal URL flags take precedence for resource loading: when `__internal_clerkJSUrl` or `__internal_clerkUIUrl` are set, the implementation loads Clerk JS/UI from those URLs and avoids using or assigning bundled constructors. Tests were expanded and setup/teardown adjusted to verify URL precedence and fallback to bundled resources when the internal flags are absent. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
__internal_clerkJSUrlnow takes precedence over the bundledClerkconstructor prop inIsomorphicClerk.getClerkJsEntryChunk__internal_clerkUIUrlnow takes precedence over the bundledui.ClerkUIconstructor prop inIsomorphicClerk.getClerkUIEntryChunkTest plan
pnpm buildpasses for@clerk/reactSummary by CodeRabbit
Tests
Bug Fixes