Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-stingrays-give.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/vue": patch
---

Fixed an issue where `useOrganization` would show an incorrect warning and dialog due to checking environment settings before Clerk was fully loaded.
70 changes: 70 additions & 0 deletions packages/vue/src/composables/__tests__/useOrganization.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import type { Clerk } from '@clerk/shared/types';
import { render } from '@testing-library/vue';
import { vi } from 'vitest';
import { defineComponent, shallowRef } from 'vue';

import { useOrganization } from '../useOrganization';

const mockAttemptToEnableEnvironmentSetting = vi.fn();

const mockLoaded = shallowRef(false);
const mockClerk = shallowRef<Partial<Clerk> | null>(null);

vi.mock('../useClerkContext', () => ({
useClerkContext: () => ({
loaded: mockLoaded,
clerk: mockClerk,
organizationCtx: shallowRef(undefined),
}),
}));

vi.mock('../useSession', () => ({
useSession: () => ({
session: shallowRef(null),
}),
}));

describe('useOrganization', () => {
beforeEach(() => {
vi.clearAllMocks();
mockLoaded.value = false;
mockClerk.value = null;
});

it('should not call __internal_attemptToEnableEnvironmentSetting before Clerk is loaded', () => {
mockClerk.value = {
__internal_attemptToEnableEnvironmentSetting: mockAttemptToEnableEnvironmentSetting,
};

const Component = defineComponent(() => {
useOrganization();
return () => null;
});

render(Component);

expect(mockAttemptToEnableEnvironmentSetting).not.toHaveBeenCalled();
});

it('should call __internal_attemptToEnableEnvironmentSetting after Clerk is loaded', async () => {
mockClerk.value = {
__internal_attemptToEnableEnvironmentSetting: mockAttemptToEnableEnvironmentSetting,
};

const Component = defineComponent(() => {
useOrganization();
return () => null;
});

render(Component);

mockLoaded.value = true;

await vi.waitFor(() => {
expect(mockAttemptToEnableEnvironmentSetting).toHaveBeenCalledWith({
for: 'organizations',
caller: 'useOrganization',
});
});
});
});
14 changes: 8 additions & 6 deletions packages/vue/src/composables/useOrganization.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,23 @@ type UseOrganization = () => ToComputedRefs<UseOrganizationReturn>;
* </template>
*/
export const useOrganization: UseOrganization = () => {
const { clerk, organizationCtx } = useClerkContext('useOrganization');
const { loaded, clerk, organizationCtx } = useClerkContext('useOrganization');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loaded ref is set to true when Clerk.load() succeeds so this is more reliable

const { session } = useSession();

watch(
clerk,
loaded,
value => {
if (value) {
// Optional chaining is important for `@clerk/vue` usage with older clerk-js versions that don't have the method
value.__internal_attemptToEnableEnvironmentSetting?.({
clerk.value?.__internal_attemptToEnableEnvironmentSetting?.({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are confident that clerk is defined here

for: 'organizations',
caller: 'useOrganization',
});
}
},
{ once: true },
{
once: true,
},
);

const result = computed<UseOrganizationReturn>(() => {
Expand All @@ -80,7 +82,7 @@ export const useOrganization: UseOrganization = () => {
}

/** In SSR context we include only the organization object when loadOrg is set to true. */
if (!clerk.value?.loaded) {
if (!loaded.value) {
return {
isLoaded: true,
organization: organizationCtx.value,
Expand All @@ -89,7 +91,7 @@ export const useOrganization: UseOrganization = () => {
}

return {
isLoaded: clerk.value.loaded,
isLoaded: loaded.value,
organization: organizationCtx.value,
membership: getCurrentOrganizationMembership(
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export const clerkPlugin: Plugin<[PluginOptions]> = {
const organizationCtx = computed(() => derivedState.value.organization);

app.provide(ClerkInjectionKey, {
loaded,
clerk,
authCtx,
clientCtx,
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import type {
import type { Component, ComputedRef, ShallowRef, Slot, VNode } from 'vue';

export interface VueClerkInjectionKeyType {
loaded: ShallowRef<boolean>;
clerk: ShallowRef<Clerk | null>;
authCtx: ComputedRef<{
userId: string | null | undefined;
Expand Down
Loading