chore(react): Remove internal and experimental JSDoc tags on signal hooks#7999
chore(react): Remove internal and experimental JSDoc tags on signal hooks#7999wobsoriano merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f3843c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThis pull request removes experimental and internal JSDoc annotations from signal hooks in the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.changeset/jolly-parents-refuse.md (1)
5-5: Consider clarifying the description to mention both tag types.The description mentions "experimental tags" but according to the AI summary, both
@internaland@experimentalJSDoc tags are being removed. Consider updating to "Remove internal and experimental tags on signal hooks" for accuracy.📝 Suggested clarification
-Remove experimental tags on signal hooks +Remove internal and experimental tags on signal hooks🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.changeset/jolly-parents-refuse.md at line 5, Update the changeset description text that currently reads "Remove experimental tags on signal hooks" to explicitly mention both JSDoc tag types by changing it to "Remove internal and experimental tags on signal hooks" so the summary accurately reflects removal of both `@internal` and `@experimental` tags; locate the string in the .changeset/jolly-parents-refuse.md file and replace it accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.changeset/jolly-parents-refuse.md:
- Line 5: Update the changeset description text that currently reads "Remove
experimental tags on signal hooks" to explicitly mention both JSDoc tag types by
changing it to "Remove internal and experimental tags on signal hooks" so the
summary accurately reflects removal of both `@internal` and `@experimental` tags;
locate the string in the .changeset/jolly-parents-refuse.md file and replace it
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: fbc3d833-5f76-4fe7-9c72-80fc92506816
📒 Files selected for processing (2)
.changeset/jolly-parents-refuse.mdpackages/react/src/hooks/useClerkSignal.ts
💤 Files with no reviewable changes (1)
- packages/react/src/hooks/useClerkSignal.ts
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit