Skip to content

fix(clerk-expo,shared): Move react dependencies from dev to peer#802

Merged
nikosdouvlis merged 1 commit into
mainfrom
expo_changes
Feb 14, 2023
Merged

fix(clerk-expo,shared): Move react dependencies from dev to peer#802
nikosdouvlis merged 1 commit into
mainfrom
expo_changes

Conversation

@nikosdouvlis
Copy link
Copy Markdown
Member

@nikosdouvlis nikosdouvlis commented Feb 14, 2023

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

A potential solution to the clerk-expo build issues.
Also closes #638 and #537

Copy link
Copy Markdown

@jit-ci jit-ci Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@nikosdouvlis nikosdouvlis linked an issue Feb 14, 2023 that may be closed by this pull request
15 tasks
@nikosdouvlis nikosdouvlis merged commit 6d33798 into main Feb 14, 2023
@nikosdouvlis nikosdouvlis deleted the expo_changes branch February 14, 2023 08:42
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared package has unnecessary peer dependency on react-test-renderer Don't work with yarn 3 and pnp

2 participants