fix(ci): skip pkglab in latest SDK mode for e2e-staging#8057
fix(ci): skip pkglab in latest SDK mode for e2e-staging#8057jacekradko merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 36db3fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA new environment variable, E2E_SDK_SOURCE, is exposed to integration tests via the e2e workflow. Application setup logic now checks E2E_SDK_SOURCE: when it equals 'latest', pkglab dependencies are installed from npm with version 'latest' and the pkglab install path is skipped; otherwise, local pkglab installation is used when pkglab dependencies are present. A new empty changeset file was added. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Comment |
Summary
sdk-source=latest, the e2e-staging workflow should install Clerk packages from npm instead of the local pkglab registryapplicationConfig.tswas skipping pkglab deps frompackage.json(expectingpkglab addto handle them), but inlatestmode no packages are published to pkglabE2E_SDK_SOURCE=latest:applicationConfig.tswrites pkglab deps aslatestinpackage.jsoninstead of skipping themapplication.tsrunspnpm installinstead ofpkglab addE2E_SDK_SOURCEenv var from the workflow to the test runnerTest plan
e2e-stagingworkflow withsdk-source=latest— tests should no longer fail withNo pkglab versions for @clerk/nextjse2e-stagingworkflow withsdk-source=ref— existing pkglab flow should still workSummary by CodeRabbit