Skip to content

fix(ci): skip pkglab in latest SDK mode for e2e-staging#8057

Merged
jacekradko merged 3 commits intomainfrom
jacek/fix-e2e-staging-pkglab-latest
Mar 12, 2026
Merged

fix(ci): skip pkglab in latest SDK mode for e2e-staging#8057
jacekradko merged 3 commits intomainfrom
jacek/fix-e2e-staging-pkglab-latest

Conversation

@jacekradko
Copy link
Copy Markdown
Member

@jacekradko jacekradko commented Mar 12, 2026

Summary

  • When sdk-source=latest, the e2e-staging workflow should install Clerk packages from npm instead of the local pkglab registry
  • The test app setup in applicationConfig.ts was skipping pkglab deps from package.json (expecting pkglab add to handle them), but in latest mode no packages are published to pkglab
  • Now when E2E_SDK_SOURCE=latest:
    • applicationConfig.ts writes pkglab deps as latest in package.json instead of skipping them
    • application.ts runs pnpm install instead of pkglab add
  • Passes E2E_SDK_SOURCE env var from the workflow to the test runner

Test plan

  • Trigger e2e-staging workflow with sdk-source=latest — tests should no longer fail with No pkglab versions for @clerk/nextjs
  • Trigger e2e-staging workflow with sdk-source=ref — existing pkglab flow should still work

Summary by CodeRabbit

  • Chores
    • Enhanced integration testing to allow selecting the SDK source used during tests.
    • Made setup logic environment-aware so package installation behavior adapts to the chosen SDK source.
    • Added a lightweight changeset placeholder to track the update.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 12, 2026

🦋 Changeset detected

Latest commit: 36db3fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 12, 2026 9:07pm

Request Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 12, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8057

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8057

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8057

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8057

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8057

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8057

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8057

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8057

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8057

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8057

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8057

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8057

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8057

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8057

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8057

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8057

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8057

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8057

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8057

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8057

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8057

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8057

commit: 36db3fc

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e2a47c4-87eb-4312-ac4f-45c8125e3a61

📥 Commits

Reviewing files that changed from the base of the PR and between 3faa11c and 36db3fc.

📒 Files selected for processing (2)
  • .changeset/brave-dogs-wave.md
  • integration/models/applicationConfig.ts

📝 Walkthrough

Walkthrough

A new environment variable, E2E_SDK_SOURCE, is exposed to integration tests via the e2e workflow. Application setup logic now checks E2E_SDK_SOURCE: when it equals 'latest', pkglab dependencies are installed from npm with version 'latest' and the pkglab install path is skipped; otherwise, local pkglab installation is used when pkglab dependencies are present. A new empty changeset file was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding logic to skip pkglab and use npm installation when E2E_SDK_SOURCE is set to 'latest' in the e2e-staging workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@jacekradko jacekradko changed the title fix(integration): skip pkglab in latest SDK mode for e2e-staging fix(ci): skip pkglab in latest SDK mode for e2e-staging Mar 12, 2026
@jacekradko jacekradko merged commit d32bf2c into main Mar 12, 2026
42 checks passed
@jacekradko jacekradko deleted the jacek/fix-e2e-staging-pkglab-latest branch March 12, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants