Skip to content

revert(expo): two-way JS/native session sync (#8032)#8065

Merged
chriscanin merged 2 commits intomainfrom
chris/revert-native-session-sync
Mar 13, 2026
Merged

revert(expo): two-way JS/native session sync (#8032)#8065
chriscanin merged 2 commits intomainfrom
chris/revert-native-session-sync

Conversation

@chriscanin
Copy link
Member

@chriscanin chriscanin commented Mar 13, 2026

Summary

Test plan

Summary by CodeRabbit

  • Bug Fixes

    • Ensure native session is reliably cleared on sign-out and avoid stale session/state after closing native UI
    • Improved initialization error handling with clearer timeout and failure messages
  • Improvements

    • Removed automatic two-way JS/native token sync to simplify session flow
    • Added additional debug logging to aid troubleshooting in development

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 13, 2026 3:45pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: 66afec3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the expo label Mar 13, 2026
@chriscanin chriscanin changed the title Revert: feat(expo): add two-way JS/native session sync (#8032) revert(expo): two-way JS/native session sync (#8032) Mar 13, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8065

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8065

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8065

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8065

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8065

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8065

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8065

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8065

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8065

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8065

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8065

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8065

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8065

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8065

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8065

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8065

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8065

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8065

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8065

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8065

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8065

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8065

commit: 66afec3

@chriscanin chriscanin merged commit 7d7d425 into main Mar 13, 2026
40 checks passed
@chriscanin chriscanin deleted the chris/revert-native-session-sync branch March 13, 2026 15:53
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: df26070f-cf0e-4a7a-bd75-46bdf4df8867

📥 Commits

Reviewing files that changed from the base of the PR and between e335f90 and 66afec3.

📒 Files selected for processing (1)
  • .changeset/revert-native-session-sync.md

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

This PR removes the two-way JavaScript/native session synchronization across the Expo package: NativeSessionSync was deleted from ClerkProvider, bidirectional token-sync paths were removed from Android and iOS native modules, and keychain/token handling was simplified to avoid cross-sync logic. Android build gradle downgrades the Clerk Android API version. iOS protocol and factory code were adjusted (getClientToken removed from the protocol, ClerkViewFactory and templates refactored). Hooks and UI components (useUserProfileModal, UserButton) were updated to rely on post-modal native session checks and simplified sign-out flows. A changeset entry was replaced.

Possibly related PRs

  • clerk/javascript PR 8032: Reverts/removes the two-way JS/native session sync features touching the same Expo native modules, token-sync logic, and provider/hooks.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 46.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: reverting a two-way JS/native session sync feature for Expo. It directly relates to the changeset content.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants