Skip to content

fix(ui,localizations): Localize API keys revoke confirmation input#8258

Merged
wobsoriano merged 4 commits intomainfrom
rob/issue-8240-fix
Apr 7, 2026
Merged

fix(ui,localizations): Localize API keys revoke confirmation input#8258
wobsoriano merged 4 commits intomainfrom
rob/issue-8240-fix

Conversation

@wobsoriano
Copy link
Copy Markdown
Member

@wobsoriano wobsoriano commented Apr 7, 2026

Description

Fixes #8240

Screenshot 2026-04-07 at 9 29 16 AM

Resolves USER-5114

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: 281a075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@clerk/localizations Patch
@clerk/shared Patch
@clerk/clerk-js Patch
@clerk/react Patch
@clerk/ui Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 7, 2026 4:12pm

Request Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 7, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8258

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8258

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8258

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8258

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8258

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8258

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8258

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8258

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8258

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8258

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8258

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8258

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8258

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8258

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8258

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8258

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8258

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8258

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8258

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8258

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8258

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8258

commit: 281a075

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

📝 Walkthrough

Walkthrough

The change adds a new Changeset and bumps versions for @clerk/localizations, @clerk/shared, and @clerk/clerk-js. It extends the localization schema with a new key for the API key revocation flow (inputLabel), adds the English string in en-US, and updates the API key revocation confirmation modal to use localized label and placeholder values and to compare the entered confirmation against the localized confirmation text with a fallback to "Revoke".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(ui,localizations): Localize API keys revoke confirmation input' clearly and specifically summarizes the main change - adding localization to the API keys revoke confirmation input.
Linked Issues check ✅ Passed The PR code changes fully address the requirements from issue #8240 by localizing the revoke confirmation input/label [#8240], enabling proper localization handling for the confirmation text.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the revoke confirmation input localization issue. The modifications to localization resources, type definitions, and UI components are all within scope [#8240].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description is related to the changeset, referencing a specific issue (#8240) and including a screenshot demonstrating the UI problem being fixed, which aligns with the localization fix for the API keys revoke confirmation modal.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano wobsoriano merged commit 4e3cb0a into main Apr 7, 2026
44 checks passed
@wobsoriano wobsoriano deleted the rob/issue-8240-fix branch April 7, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Keys: "Revoke" button in Clerk Dashboard does not work

2 participants