chore(repo): make pnpm dev:sandbox work from any directory#8259
chore(repo): make pnpm dev:sandbox work from any directory#8259jacekradko merged 2 commits intomainfrom
Conversation
Rename the inner rspack dev:sandbox tasks in @clerk/clerk-js and @clerk/ui to dev:sandbox:serve and add proxy scripts that bounce to the workspace root via pnpm -w dev:sandbox. Running pnpm dev:sandbox from root, packages/clerk-js, or packages/ui now consistently starts both rspack servers, so the UI components always load into the sandbox. Playwright's webServer is pinned to pnpm dev:sandbox:serve so its direct rspack behavior is preserved.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0aa7490 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request refactors sandbox dev tooling by splitting the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Summary
pnpm dev:sandboxnow starts both the@clerk/clerk-jsand@clerk/uirspack dev servers whether you run it from the repo root,packages/clerk-js, orpackages/ui. Previously it only worked from the root — running it from insidepackages/clerk-jssilently launched just the clerk-js server, so the sandbox loaded without UI components.@clerk/clerk-jsand@clerk/uiare renameddev:sandbox→dev:sandbox:serve(in bothpackage.jsonscripts andturbo.jsontask definitions). Newdev:sandboxscripts in those packages proxy to the workspace root viapnpm -w dev:sandbox, so the rootturbo dev:sandbox:servefans out to both packages no matter where you invoke from.webServerinpackages/clerk-js/playwright.config.tsis pinned topnpm dev:sandbox:serveto keep its current direct-rspack behavior (port 4000 only, no turbo build dep).Test plan
pnpm dev:sandboxfrom repo root → both rspack servers up (unchanged behavior)pnpm dev:sandboxfrompackages/clerk-js→ proxies to root → both servers uphttp://localhost:4000loads and referenceshttp://localhost:4011/npm/ui.browser.js:4011/npm/ui.browser.jsreturns 200 (verified live against the running dev servers)turbo run dev:sandbox:serve --dry-rundiscovers the task in both@clerk/clerk-jsand@clerk/uipnpm buildpasses (21/21 tasks successful)cd packages/clerk-js && pnpm test:sandbox:integration(Playwright sandbox suite)