Skip to content

fix(integration): remove custom build script override in astro prod test#8321

Merged
jacekradko merged 2 commits into
release/core-2from
jacek/fix-astro-prod-build-test
Apr 15, 2026
Merged

fix(integration): remove custom build script override in astro prod test#8321
jacekradko merged 2 commits into
release/core-2from
jacek/fix-astro-prod-build-test

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Summary

  • Removes the custom pnpm astro build script override in the astro production build middleware test, which was causing CI build failures

Test plan

  • Astro integration tests pass in CI

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 15, 2026 6:44pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca535d7e-0bdf-4041-8f7e-97f9365f0563

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jacek/fix-astro-prod-build-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

⚠️ No Changeset found

Latest commit: a365eea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 15, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8321

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8321

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8321

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8321

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8321

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8321

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@8321

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@8321

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8321

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8321

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8321

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8321

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8321

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8321

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@8321

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8321

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@8321

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8321

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8321

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8321

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@8321

@clerk/types

npm i https://pkg.pr.new/@clerk/types@8321

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8321

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8321

commit: a365eea

The template's default build script runs 'astro check && astro build',
which validates config and fails on NaN port (PORT unset during build).
Override with 'npx astro build' and provide a config with port fallback.
@jacekradko jacekradko merged commit 8b76202 into release/core-2 Apr 15, 2026
74 of 77 checks passed
@jacekradko jacekradko deleted the jacek/fix-astro-prod-build-test branch April 15, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants