Skip to content

chore(clerk-js,shared): Add dev error when session is missing for OAuthConsent#8335

Merged
wobsoriano merged 4 commits intomainfrom
rob/oauth-consent-dev-message-no-session
Apr 16, 2026
Merged

chore(clerk-js,shared): Add dev error when session is missing for OAuthConsent#8335
wobsoriano merged 4 commits intomainfrom
rob/oauth-consent-dev-message-no-session

Conversation

@wobsoriano
Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 16, 2026 4:21pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2026

🦋 Changeset detected

Latest commit: 8ba7a10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/chrome-extension Patch
@clerk/expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 80796a29-7953-4649-8473-bf65109a682e

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee6a32 and 8ba7a10.

📒 Files selected for processing (3)
  • .changeset/happy-drinks-ring.md
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/internal/clerk-js/warnings.ts

📝 Walkthrough

Walkthrough

A new runtime validation is introduced to prevent mounting the <OAuthConsent/> component when no user session exists. The Clerk.__internal_mountOAuthConsent method is updated to check for user existence and throw a development-time error if the component is mounted without an active session. A corresponding warning message is added to the warnings module, and a changeset entry documents the patch-version updates to @clerk/clerk-js and @clerk/shared.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a standard PR template with checklist items but lacks specific details about the changes introduced in this PR. Consider adding a brief explanation of what the change does (e.g., 'Adds a development error when OAuthConsent is used without an active session') and how to test it.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a development-time error when OAuthConsent is mounted without an active session.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8335

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8335

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8335

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8335

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8335

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8335

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8335

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8335

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8335

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8335

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8335

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8335

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8335

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8335

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8335

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8335

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8335

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8335

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8335

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8335

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8335

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8335

commit: 8ba7a10

@wobsoriano wobsoriano merged commit 34762e8 into main Apr 16, 2026
71 of 72 checks passed
@wobsoriano wobsoriano deleted the rob/oauth-consent-dev-message-no-session branch April 16, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants