-
Notifications
You must be signed in to change notification settings - Fork 448
chore(express,react,shared): Support dynamic options callback in clerkMiddleware #8398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
866e5af
docs: add accounts portal OAuth consent refactor spec
wobsoriano ad0617c
feat(express): support dynamic options callback in clerkMiddleware
wobsoriano 1a28062
chore: remove doc
wobsoriano 26f6335
Merge branch 'main' into rob/express-sdk-dynamic-keys
wobsoriano 57f8b79
chore: add changeset
wobsoriano 5edd005
chore: update changeset
wobsoriano 20655d2
feat(shared): add publishableKeyFromHost utility for multi-domain setups
wobsoriano c3420c8
feat(express): expose publishableKeyFromHost from internal path
wobsoriano bb09a5a
fix(shared): restore fallbackKey param in publishableKeyFromHost
wobsoriano 70bd92b
update doc
wobsoriano d22bfd5
chore: add changeset for publishableKeyFromHost
wobsoriano 12b1749
chore: trim express changeset to high-level description
wobsoriano 069ef1e
chore: consolidate changesets
wobsoriano 08143ce
chore: split changesets by package group
wobsoriano 5dee2cc
test(shared): add unit tests for publishableKeyFromHost
wobsoriano a9a225e
fix(shared): Strip port from host in publishableKeyFromHost and updat…
wobsoriano ac4550b
fix(shared): Guard against empty host and add trust proxy note in pub…
wobsoriano 4c66694
fix(shared): Align empty host error message with codebase conventions
wobsoriano 62709fa
refactor(express): Remove internal re-export of publishableKeyFromHost
wobsoriano 14d8fd9
docs(shared): Show allowlist pattern in publishableKeyFromHost Expres…
wobsoriano f48bd81
docs(express): Remove secretKey from clerkMiddleware dynamic keys exa…
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@clerk/shared": patch | ||
| "@clerk/react": patch | ||
| --- | ||
|
|
||
| Add `publishableKeyFromHost` utility for resolving the correct publishable key per hostname in multi-domain setups. Re-exported from `@clerk/react/internal`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@clerk/express": patch | ||
| --- | ||
|
|
||
| Support dynamic options callback in `clerkMiddleware` for multi-domain and multi-tenant setups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.