Skip to content

fix(ui): Configure SSO copy button loading state#8592

Merged
wobsoriano merged 5 commits into
mainfrom
carp/fix-copy-button-loading-spinner
May 18, 2026
Merged

fix(ui): Configure SSO copy button loading state#8592
wobsoriano merged 5 commits into
mainfrom
carp/fix-copy-button-loading-spinner

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

Description

BEFORE

befor.mov

AFTER

afer.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 18, 2026 8:40pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

🦋 Changeset detected

Latest commit: c7848ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the ui label May 18, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8c070733-b80d-440c-bb10-29486ec61f6a

📥 Commits

Reviewing files that changed from the base of the PR and between 128b7d9 and c7848ee.

📒 Files selected for processing (1)
  • packages/ui/src/components/ConfigureSSO/steps/TestConfigurationStep.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ui/src/components/ConfigureSSO/steps/TestConfigurationStep.tsx

📝 Walkthrough

Walkthrough

This PR fixes a layout shift issue in the <ConfigureSSO /> component's Copy test URL button. The CopyTestUrlButton component was refactored to use conditional inline Spinner rendering instead of the button component's isLoading and loadingText props. When the button is in a loading state (isCreatingTestRun), it now displays a Spinner while remaining disabled. Otherwise, it displays the copy or check icon. The change is documented in a new Changesets entry for a patch release.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • clerk/javascript#8544: Modifies the <ConfigureSSO /> test-step flow and CopyTestUrlButton behavior in the same component.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: addressing the loading state behavior of the copy button in the Configure SSO component.
Description check ✅ Passed The description relates to the changeset by providing before/after preview links showing the loading state fix, though it lacks detailed explanation of the technical change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 18, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8592

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8592

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8592

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8592

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8592

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8592

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8592

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8592

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8592

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8592

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8592

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8592

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8592

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8592

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8592

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8592

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8592

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8592

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8592

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8592

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8592

commit: c7848ee

@wobsoriano wobsoriano merged commit 761ebdd into main May 18, 2026
43 checks passed
@wobsoriano wobsoriano deleted the carp/fix-copy-button-loading-spinner branch May 18, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants