chore(ui,shared,localizations): UX improvements for <ConfigureSSO />#8601
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: e64ecc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ba679b7 to
9774083
Compare
1279e85 to
23d3243
Compare
dc5d30e to
f1c419e
Compare
<ConfigureSSO />
<ConfigureSSO /><ConfigureSSO />
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates Configure SSO end-to-end: many locale files now reference Single Sign-On (SSO) and simplify the select-provider localization shape; shared localization types were adjusted (selectProviderStep, testUrl action label, testResults.empty, provider-specific saml attributeMapping); UI changes include rehydrating provider selection, removing enterprise-connection creation from verify-domain, conditional mounting of select-provider, changing the permission key to org:sys_entconns:manage, refactoring ConfigureStep to provider-driven attribute mapping, adding an Open test URL flow and test-results empty state, instrumenting UI with elementDescriptor/elementId keys, and adding a primary-email-domain footer in the navbar. Tests were updated to reflect copy and permission-key changes. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
| <Text | ||
| as='p' | ||
| colorScheme='secondary' | ||
| localizationKey={localizationKeys('configureSSO.configureStep.attributeMapping.paragraph')} | ||
| /> |
There was a problem hiding this comment.
I'll refactor this one on a next PR where I'll introduce better support for UI per IdP!
| <Th> | ||
| <Text | ||
| sx={theme => ({ fontSize: theme.fontSizes.$xs })} | ||
| localizationKey={config.columns.second} |
There was a problem hiding this comment.
In the designs, this column is now "Expression", currently as Value, but I think we can update it later, not sure if it is intended.
| ); | ||
| }; | ||
| as='span' | ||
| colorScheme={config.monoFirst ? undefined : 'secondary'} |
There was a problem hiding this comment.
Noticed this column is always secondary even with mono in the designs, adding as a note to check what is the right one, we can fix later too.
There was a problem hiding this comment.
I recognize this abstraction is bad, so I'll likely remove it on a next PR
Reason why, custom SAML attribute mapping table doesn't have a fixed attribute name to use mono, as it could be anything on the custom provider, so we use labels.
Okta uses the actual attribute name on the first column, therefore mono.
e60f168 to
b04a165
Compare
b04a165 to
7a92e31
Compare
7a92e31 to
e64ecc6
Compare

Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change