chore(upgrade): Remove dead generate-changelog file#8686
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b96812d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR removes the unused Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/warm-spies-clean.md:
- Around line 1-2: The changeset file .changeset/warm-spies-clean.md is empty
but must include a version bump for the public package `@clerk/upgrade` because
removing packages/upgrade/src/util/generate-changelog.js affects the published
dist; update the changeset to include a package entry (for example
`"`@clerk/upgrade`": patch`) and a short summary like "Remove unused
generate-changelog utility" so the package version is bumped when releasing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 507e8ba7-24da-4ac1-b7a4-d131157a4ea8
📒 Files selected for processing (1)
.changeset/warm-spies-clean.md
| --- | ||
| --- |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if `@clerk/upgrade` is a published package and verify the removed file
# Check if the package is published (look for private field)
echo "=== Checking package.json for `@clerk/upgrade` ==="
cat packages/upgrade/package.json | jq '{name: .name, version: .version, private: .private}'
# Verify if generate-changelog.js existed and check for any imports
echo -e "\n=== Checking for references to generate-changelog ==="
rg -n "generate-changelog" --type=js --type=ts -g '!node_modules' -g '!.changeset' -C2Repository: clerk/javascript
Length of output: 236
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Inspect changeset file ==="
ls -la .changeset/warm-spies-clean.md || true
cat -n .changeset/warm-spies-clean.md || true
echo "=== Inspect changesets config ==="
ls -la .changeset || true
ls -la .changeset/config.json .changeset/config.* 2>/dev/null || true
if [ -f .changeset/config.json ]; then
cat .changeset/config.json
fi
echo "=== Check whether generate-changelog.js still exists ==="
fd -a "generate-changelog\.js" . || true
fd -a "generate-changelog" packages -t f || true
echo "=== Verify whether `@clerk/upgrade` is public and what scripts use changesets ==="
cat -n packages/upgrade/package.json | sed -n '1,120p'
rg -n "\"changeset\"|changeset|`@changesets`" package.json packages -S --glob '!**/node_modules/**' || trueRepository: clerk/javascript
Length of output: 4225
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Locate removed file (src/util/generate-changelog.js) ==="
fd -a "generate-changelog\.js" packages/upgrade -t f || true
ls -la packages/upgrade/src/util 2>/dev/null || true
echo "=== Search for references to generate-changelog across the package ==="
rg -n "generate-changelog" packages/upgrade -S --glob '!**/node_modules/**' || true
echo "=== Search for generate/changelog patterns (to catch renamed imports) ==="
rg -n "(generate.*changelog|changelog.*util|generateChangelog)" packages/upgrade/src -S --glob '!**/node_modules/**' || true
echo "=== Check if dist exists and whether it would have contained it ==="
ls -la packages/upgrade/dist 2>/dev/null || true
fd -a "generate-changelog" packages/upgrade/dist -t f 2>/dev/null || trueRepository: clerk/javascript
Length of output: 704
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Search for 'changeset --empty' usage/docs ==="
rg -n "changeset:empty|--empty|empty changeset" package.json .changeset -S || true
echo "=== Read .changeset/README.md (look for empty changesets guidance) ==="
sed -n '1,200p' .changeset/README.md || true
sed -n '200,500p' .changeset/README.md || true
echo "=== Inspect root changeset changelog/build scripts (if any) ==="
rg -n "changeset( publish| version| --empty)" package.json -S || trueRepository: clerk/javascript
Length of output: 1271
Add a version bump for @clerk/upgrade (don’t keep this changeset empty)
@clerk/upgrade is public (publishConfig.access: "public", files: ["dist"]) and its build runs Babel over the whole src tree with --copy-files, so removing packages/upgrade/src/util/generate-changelog.js changes what ends up in the published dist. Replace the empty changeset with a package version entry, e.g.:
---
"`@clerk/upgrade`": patch
---
Remove unused generate-changelog utility🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/warm-spies-clean.md around lines 1 - 2, The changeset file
.changeset/warm-spies-clean.md is empty but must include a version bump for the
public package `@clerk/upgrade` because removing
packages/upgrade/src/util/generate-changelog.js affects the published dist;
update the changeset to include a package entry (for example `"`@clerk/upgrade`":
patch`) and a short summary like "Remove unused generate-changelog utility" so
the package version is bumped when releasing.
There was a problem hiding this comment.
Agree. This does change the published dist, so a changeset is needed
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
jacekradko
left a comment
jacekradko
left a comment
There was a problem hiding this comment.
Looks good, but we should add a changeset for correctness
dominic-clerk
force-pushed
the
dc-remove-dead-generate-changelog
branch
from
615815b to
543abd7
Compare
|
Actionable comments posted: 0 |
2 participants
Description
This appears not to be used at all and refers to a
../versions/v5path that doesn't exist anymore.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change