fix(expo): Bump clerk-android to 1.0.18#8716
Conversation
🦋 Changeset detectedLatest commit: 8907538 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/expo/android/build.gradle (1)
21-22: ⚡ Quick winAdd regression coverage for the Android IME submit behavior.
This dependency bump fixes a user-facing Android input behavior, but no tests were added in this PR. Please add/update tests that cover Enter/Return triggering submission (not newline) for affected auth inputs.
As per coding guidelines: “If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/expo/android/build.gradle` around lines 21 - 22, The bump of clerkAndroidApiVersion and clerkAndroidUiVersion changed Android IME submit behavior but no tests were added; add Android UI tests that assert Enter/Return triggers form submission (IME_ACTION_DONE/IME_ACTION_SEND) and not a newline for the affected auth inputs. Specifically, add or update instrumented tests (e.g., Espresso) for the auth input fields used by the Clerk auth screens to send an IME action and verify the submission handler is invoked (or newline is not inserted), and add unit/roboletric tests where possible to cover input handling logic in the auth component so future bumps don’t regress this behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/expo/android/build.gradle`:
- Around line 21-22: The bump of clerkAndroidApiVersion and
clerkAndroidUiVersion changed Android IME submit behavior but no tests were
added; add Android UI tests that assert Enter/Return triggers form submission
(IME_ACTION_DONE/IME_ACTION_SEND) and not a newline for the affected auth
inputs. Specifically, add or update instrumented tests (e.g., Espresso) for the
auth input fields used by the Clerk auth screens to send an IME action and
verify the submission handler is invoked (or newline is not inserted), and add
unit/roboletric tests where possible to cover input handling logic in the auth
component so future bumps don’t regress this behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: a7729c74-7775-4f80-8c9b-467c6a8d58fa
📒 Files selected for processing (2)
.changeset/expo-bump-clerk-android-1-0-18.mdpackages/expo/android/build.gradle
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
Break Check: no API changes detected across the tracked packages. |
wobsoriano
changed the title
wobsoriano
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/expo/android/build.gradle (1)
21-22: ⚡ Quick winAdd verification or integration tests for the dependency upgrade.
No tests were added as part of this PR. Consider adding or running integration tests to verify that the Clerk Android SDK upgrade doesn't introduce regressions, particularly for the IME/keyboard action handling mentioned in the PR description.
As per coding guidelines, tests should be added to cover changes when none are included in the PR.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/expo/android/build.gradle` around lines 21 - 22, The PR updates clerkAndroidApiVersion and clerkAndroidUiVersion to "1.0.18" but lacks tests; add integration/verification tests that exercise the upgraded Clerk Android SDK (focus on IME/keyboard action handling described in the PR) to catch regressions: create an automated test that boots the Android view hosting Clerk UI, simulates keyboard/IME actions (submit/done/next) and asserts expected callbacks/submit behavior and focus changes, and add a CI job or local integration test script to run these tests against the new versions; reference the updated version constants clerkAndroidApiVersion and clerkAndroidUiVersion when wiring the test dependency resolution so the tests run against 1.0.18.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/android/build.gradle`:
- Around line 21-22: The build.gradle variables clerkAndroidApiVersion and
clerkAndroidUiVersion are set to "1.0.18" but the PR claims a bump to
1.0.19—update these two variables in packages/expo/android/build.gradle to the
intended release "1.0.19" (or change the PR title/commit to match "1.0.18") and
verify the chosen version exists on Maven Central for
com.clerk:clerk-android-api and com.clerk:clerk-android-ui (search.maven.org);
after updating, add a lightweight Android CI smoke/compile job that performs a
Gradle assemble or dependency resolution to ensure the bumped artifacts resolve
and the project builds.
---
Nitpick comments:
In `@packages/expo/android/build.gradle`:
- Around line 21-22: The PR updates clerkAndroidApiVersion and
clerkAndroidUiVersion to "1.0.18" but lacks tests; add integration/verification
tests that exercise the upgraded Clerk Android SDK (focus on IME/keyboard action
handling described in the PR) to catch regressions: create an automated test
that boots the Android view hosting Clerk UI, simulates keyboard/IME actions
(submit/done/next) and asserts expected callbacks/submit behavior and focus
changes, and add a CI job or local integration test script to run these tests
against the new versions; reference the updated version constants
clerkAndroidApiVersion and clerkAndroidUiVersion when wiring the test dependency
resolution so the tests run against 1.0.18.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 0f55ef55-05ef-473e-9350-5e7aed06f75f
📒 Files selected for processing (2)
.changeset/expo-bump-clerk-android-1-0-18.mdpackages/expo/android/build.gradle
✅ Files skipped from review due to trivial changes (1)
- .changeset/expo-bump-clerk-android-1-0-18.md
3 participants
Description
Resolves the android part of #8611 and #8346
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change